Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Jira
    • Jira
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !44694

SiDigitization changes for use by HGTD

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nicholas Styles requested to merge nstyles/athena:21.9-backportSiDigiUpdates into 21.9 Jun 24, 2021
  • Overview 21
  • Commits 6
  • Pipelines 4
  • Changes 13

Backporting changes from !42152 (merged) to allow !41919 (closed) to proceed.

Since the HGTD will use common ReadoutGeometry base classes, it should also use a common base for Digitization.

This update allows for HGTD Digitization to use SiChargedDiode/SiChargedDiodeCollection etc by making them use ReadoutGeometryBase classes rather than InDetReadoutGeometry.

Interface classes such as ISCT_Amp, ISCT_FrontEnd etc are added such that they can be used for HGTD as well. In a future MR the old interfaces will be moved out of SCT_Digitization, and the inheritance of the derived implementations there updated to use the new abstract interfaces added here.

FYI @cohm @tawang @dshope

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 21.9-backportSiDigiUpdates