Skip to content
Snippets Groups Projects

FFJetmearingTool memory leak bugfix

Merged Oliver Majersky requested to merge omajersk/athena:FFJetSmearingTool-memleak-bugfix into 21.2

As the title says, there is a memory leak in the FFJetSmearingTool when reading histograms from TFile and passing them to unique_ptr, in the process a copy is made, and the original instance is not cleaned up (why it is not cleaned up when the TFile is closed is not entirely clear to me. The file appears to own the histograms at first glance).

The drop in memory consumption is quite drastic (~ 500MB cca) because the actual histograms being read are very huge in terms of number of bins -- this is separate issue being followed up with JetEtMiss experts.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading