Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 147
    • Merge requests 147
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !44732

FFJetmearingTool memory leak bugfix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Oliver Majersky requested to merge omajersk/athena:FFJetSmearingTool-memleak-bugfix into 21.2 Jun 25, 2021
  • Overview 22
  • Commits 3
  • Pipelines 5
  • Changes 1

As the title says, there is a memory leak in the FFJetSmearingTool when reading histograms from TFile and passing them to unique_ptr, in the process a copy is made, and the original instance is not cleaned up (why it is not cleaned up when the TFile is closed is not entirely clear to me. The file appears to own the histograms at first glance).

The drop in memory consumption is quite drastic (~ 500MB cca) because the actual histograms being read are very huge in terms of number of bins -- this is separate issue being followed up with JetEtMiss experts.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: FFJetSmearingTool-memleak-bugfix