Skip to content

22.0-cppcheck-TrigFastTrackFinder

Shaun Roe requested to merge sroe/athena:22.0-cppcheck-TrigFastTrackFinder into master

cppcheck reported access out of bounds for TrigFastTrackFinder. This has been solved by making the return type of getTrkBarrelLayerInfo a std::array of a newly introduced struct, OneLayerInfo_t (protected). Previously a series of vectors were passed by non-const reference, with dimension resized to a hardcoded 8 in the function. This dimension has been made explicit in the header with a static constexpr variable, N_BARREL_LAYERS. Minor cleanup of the header includes, and one postfix->prefix change also done.

Merge request reports