Skip to content
Snippets Groups Projects

AFP+dijet chains based on simple hypo alg

Merged AFP+dijet chains based on simple hypo alg
amoreira/athena:TrigAFPDev into master
All threads resolved!
Merged Ana Luisa Moreira De Carvalho requested to merge amoreira/athena:TrigAFPDev into master
All threads resolved!

Implementation of AFP+dijet chain based on a simple hypo that runs after AFP and jet reconstruction and that just fetches the jet and AFP track collections. Needed because the fix provided in ATR-23731 for the combo hypo tool base does not solve the problem for the AFP+dijet chain.

Merge request reports

Checking pipeline status.

Merged by Johannes ElmsheuserJohannes Elmsheuser 3 years ago (Jul 16, 2021 8:49am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ana Luisa Moreira De Carvalho added 1 commit

    added 1 commit

    Compare with previous version

  • Ana Luisa Moreira De Carvalho resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 108K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/LS2_v1.py

    :pencil: 136K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Trigger/TrigHypothesis/TrigAFPHypo
    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TriggerTest
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@dzanzi ,@iriu ,@vmartin ,@okumura ,@carquin ,@ademaria ,@bernius ,@hrussell ,@malconad ,@ggach as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 6ffc25ca)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 36837]

  • Ana Luisa Moreira De Carvalho added 1 commit

    added 1 commit

    • d4bd82a3 - Addressing review comments related to code changes, still missing units

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 108K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/LS2_v1.py

    :pencil: 136K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Trigger/TrigHypothesis/TrigAFPHypo
    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TriggerTest
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@dzanzi ,@iriu ,@vmartin ,@okumura ,@carquin ,@ademaria ,@bernius ,@hrussell ,@malconad ,@ggach as watchers

  • Ana Luisa Moreira De Carvalho added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 108K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/LS2_v1.py

    :pencil: 136K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Trigger/TrigHypothesis/TrigAFPHypo
    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TriggerTest
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@dzanzi ,@iriu ,@vmartin ,@okumura ,@carquin ,@ademaria ,@bernius ,@hrussell ,@malconad ,@ggach as watchers

  • Ana Luisa Moreira De Carvalho resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash d4bd82a3)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 36876]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash bd456421)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 36881]

  • Clara Nellist
    Clara Nellist @cnellist ·
    Developer

    MR has previously been reviewed by an L1, so sending on to L2 since there are many changes. Clara (L1)

  • Clara Nellist added review-pending-level-2 label and removed review-pending-level-1 label

    added review-pending-level-2 label and removed review-pending-level-1 label

  • Abhishek Nag
    Abhishek Nag @abnag ·

    MR looks good. Approving.

    Cheers, Abhishek [L2]

  • Abhishek Nag added review-approved label and removed review-pending-level-2 label

    added review-approved label and removed review-pending-level-2 label

  • Johannes Elmsheuser merged

    merged

  • Johannes Elmsheuser mentioned in commit b6c025b2

    mentioned in commit b6c025b2

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

  • Ana Luisa Moreira De Carvalho mentioned in merge request !45373 (merged)

    mentioned in merge request !45373 (merged)

    • Please register or sign in to reply