Add support for VR jets in JetClusterer

The new jet configuration (Release 22, AthenaMT) does not support VR jet building. In order to implement VR jets, changes were made to JetClusterer and JetRecConfig . Since VR JetDefinition requires mass scale and minimum jet radius, some changes in the JetDefinition class were necessary. In order to support (VR) track jets, which are built from primary vertex tracks, changes were made to JetInputConfig and StandardJetConstits. Finally, to test the changes, custom VR JetDefinition was added to StandardSmallRJets; this JetDefinition in turn is used by test_StandardJets.

added JetEtmiss label

added 1 commit

• 76d0d18e - Revert to the original test input file path

Compare with previous version

added 2 commits

• f091bcf2 - Add standard VR track jet definition and fix memory management of VR jet plugin
• d0447edb - Merge branch 'vr-jets-jetclusterer' of ssh://gitlab.cern.ch:7999/rjoshi/athena...

Compare with previous version

Are there any other comments?

added 1 commit

• 411a68d4 - Fix variable names related to VR jets

Compare with previous version

@wbalunas Can this merge request be marked ready now?

Yes, all of my comments have been addressed. If you've tested it locally and found that it works, you can go ahead.

marked this merge request as ready

resolved all threads

This merge request affects 2 packages:

• Reconstruction/Jet/JetRec
• Reconstruction/Jet/JetRecConfig

Affected files list will not be printed in this case

Adding @goetz as watcher

added Reconstruction analysis-review-required master review-pending-level-1 labels

CI Result SUCCESS (hash 411a68d4)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 37091]

added review-user-action-required label and removed review-pending-level-1 label

Changed the label for now, please undo as soon as all threads are resolved.

Cheers, Martin (L1)

added 1 commit

• 8fb3d20c - Removed unnecessary preprocessor directives

Compare with previous version

This merge request affects 2 packages:

• Reconstruction/Jet/JetRec
• Reconstruction/Jet/JetRecConfig

Affected files list will not be printed in this case

Adding @goetz as watcher

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 8fb3d20c)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 37135]

Hi @rjoshi, please resolve open thread

Sergei L1

resolved all threads

resolved all threads

Looks good. Approved

Sergei L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 89c2db63

added sweep:ignore label