Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 167
    • Merge requests 167
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !45356

Activate FE-mask (ATLASRECTS-6437, ATLASRECT-6322)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Soshi Tsuno requested to merge stsuno/athena:atlasrects-6437 into master Jul 22, 2021
  • Overview 94
  • Commits 7
  • Pipelines 4
  • Changes 5

So far, the conditions tag was forced to pass all q-tests that are still using old conditions tag. Since the q-tests update to use the latest global tag, such issue should not exist. Thus, remove the unnecessary lines, and FE-masking is activated.

Caveat:

  • During the test, I found a bug in the conditions in MC. PixelModuleFeMask-SIM-MC16-000-04 is buggy and used since OFLCOND-MC16-SDR-RUN2-03. We definitely fix this conditions bug (not athena).

  • I guess current q-tests still not update the global tag. So that, I guess all q-tests will fail. This can be discussed during this MR.

  • Trigger needs new folder, /PIXEL/Onl/PixelModuleFeMask

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: atlasrects-6437