Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 145
    • Merge requests 145
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !45406

Setting the default sde_strategy in MadGraphControl

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Zach Marshall requested to merge zmarshal/athena:21.6_MGC_sde_strategy_default into 21.6 Jul 23, 2021
  • Overview 5
  • Commits 1
  • Pipelines 1
  • Changes 1

In versions of MadGraph newer than 2.9, there's an sde_strategy run parameter that defines how the job does the integration. It's a change of strategy that may behave better under some circumstances. We have seen in the validation, AGENE-2038, that this strategy is automatically set based on the process being used. This seems confusing, and the automatic setting doesn't always align with what is naively expected.

After some discussion, we decided to always set the default strategy, and of course to allow the user to change the strategy if they choose to do so. This MR updates the run card as soon as a new process is defined to ensure that the default strategy is used. If the user chooses to set the new strategy they'll be able to do so, and their setting will not be overridden. This has become AGENE-2063

I took the opportunity to clean up a couple other cases where the run card was being modified and we were being overlay prescriptive about what to set.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 21.6_MGC_sde_strategy_default