Skip to content
Snippets Groups Projects

testing changes in TrigHypoCommonTools: extend the module for considering multiple hypos ATR-21565 ATR-23880

Merged Gianantonio Pezzullo requested to merge gipezzul/athena:comboHypoTest0 into master

Now the ComboHypoTool is capable to implement the AND of multiple hypos. I added two new chains photon+MET that I used to test changes I made. Please note, the monitoring tool behaves in a slightly different way when the chain has multiple comboHypo to combine. In case we have N hypos, the module will:

  1. create N different histogram;
  2. the histograms for the processed events will have different number of entries, because the module stops as soon as a hypo fails the condition(s).
Edited by Gianantonio Pezzullo

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Teng Jian Khoo
  • added 3 commits

    • 9aaef0d6 - added new photon+MET chain with multiple comboHypos
    • 07d75c26 - changes necessary to handle multiple comboHypos/chain
    • e57f21b2 - updates

    Compare with previous version

  • Hi folks,

    I successfully run the following test: athena.py -c "setMenu='LS2_v1';doWriteBS=False;doWriteRDOTrigger=True;selectChains=['HLT_g25_tight_icalotight_xe40_cell_xe50_tcpufit_18dphiAB_18dphiAC_80mTAC_L1EM22VHI']" --imf --perfmon --threads=1 --evtMax=100 --filesInput=/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/TriggerTest/valid1.410000.PowhegPythiaEvtGen_P2012_ttbar_hdamp172p5_nonallhad.merge.RDO.e4993_s3214_r11315/RDO.17533168._000001.pool.root.1,/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/TriggerTest/valid1.410000.PowhegPythiaEvtGen_P2012_ttbar_hdamp172p5_nonallhad.merge.RDO.e4993_s3214_r11315/RDO.17533168._000002.pool.root.1 TriggerJobOpts/runHLT_standalone.py >| athena_debug.log 2>&1 &

    and the job completed w/o errors and the expert-monitoring.root file was built properly.

    I'm now running the minimal art tests to check what happens in the other chains that use a comboHypo.

    Cheers,

    Giani

  • added 3 commits

    • d4292695 - added another photon+MET chain
    • 91ccb346 - improvements in the logic and the handling of the monitorining hists
    • 5c089d74 - clean up the code

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Gianantonio Pezzullo marked this merge request as ready

    marked this merge request as ready

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/LS2_v1.py

    :pencil: 136K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

  • This merge request affects 4 packages:

    • Trigger/TrigHypothesis/TrigHypoCommonTools
    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TriggerTest
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@ademaria ,@iriu ,@vmartin ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

  • Gianantonio Pezzullo changed the description

    changed the description

  • Gianantonio Pezzullo resolved all threads

    resolved all threads

  • Gianantonio Pezzullo changed title from testing changes in TrigHypoCommonTools: extend the module for considering multiple hypos ATR-21565 to testing changes in TrigHypoCommonTools: extend the module for considering multiple hypos ATR-21565 ATR-23880

    changed title from testing changes in TrigHypoCommonTools: extend the module for considering multiple hypos ATR-21565 to testing changes in TrigHypoCommonTools: extend the module for considering multiple hypos ATR-21565 ATR-23880

  • :white_check_mark: CI Result SUCCESS (hash cbbb11e3)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 37268]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading