Add LArSamplesMon package to athena

This MR concerns the implementation of the LArSamplesMon package with changes and migration to release 22. This package contains tools to read ntuples and create histograms to study the LAr pulse shapes and FEBs timing. More documentation about this package can be found on the twiki: https://twiki.cern.ch/twiki/bin/view/LAr/LArSamplesMon

Tagging @pavol and @wlampl to follow up as well on this MR.

This merge request affects 1 package:

• LArCalorimeter/LArSamplesMon

This merge request affects 88 files. Since this is a long list, it will not be printed.

Adding @pavol as watcher

added JetEtmiss LAr master review-pending-level-1 labels

CI Result FAILURE (hash be57b34a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 37290]

Changing label to review-user-action-required while the CI pipeline failure is investigated. Clara (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 95df0d9c - remove duplicated classes, changes in CMakeLists.txt, and adding copyrights

Compare with previous version

This merge request affects 1 package:

• LArCalorimeter/LArSamplesMon

This merge request affects 88 files. Since this is a long list, it will not be printed.

Adding @pavol as watcher

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 95df0d9c)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 37367]

This MR adds new classes and their implementation. redirect to L2

Sergei L1

added review-pending-level-2 label and removed review-pending-level-1 label

Hi @kalkhour, I am looking into this MR and will add my comments, but it might take me some time. By the time, if you can tag an expert to have a look as well, then it would be great.

Thanks, Abhishek [L2]

added review-pending-expert label

I'm aware of this MR, and I would like to add, that this package is a migrated version of the code which was in SVN repo, but was not imported to git, waiting for cleanup, done now. In addition this code is not used in standard reconstruction, it is used in processing of output of special streams processing on CAF, which for the moment is not planned to run MT (because is mostly I/O bound, not memory or CPU). To me it's fine to merge this code.

   Thanks,
              Pavol

removed review-pending-expert label

Thanks @pavol, The MR looks good to me as well. Approving

Cheers, Abhishek [L2]

added review-approved label and removed review-pending-level-2 label

@abnag, how can you approve this if the latest CI pipeline still shows warnings?

added review-user-action-required label

removed review-approved label