Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 147
    • Merge requests 147
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !45467

Add StoreGate WARNING pattern associated with direct access to errorRegex

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Stewart Martin-Haugh requested to merge smh/athena:check_for_direct_SG_access into master Jul 27, 2021
  • Overview 12
  • Commits 2
  • Pipelines 1
  • Changes 1

Make these warnings:

StoreGateSvc                                     WARNING Called retrieve() on these objects in a MT store
StoreGateSvc                                     WARNING L1MUINT::MuCTPIToRoIBSLink/ [LVL1::L1TopoSimulation/L1LegacyTopoSimulation]
StoreGateSvc                                     WARNING LVL1::eFEXOutputCollection/eFEXOutputCollection [LVL1::eFEXDriver/eFEXDriver]
StoreGateSvc                                     WARNING LVL1::jFEXOutputCollection/jFEXOutputCollection [LVL1::jFEXDriver/jFEXDriver]
StoreGateSvc                                     WARNING Called record() on these objects in a MT store
StoreGateSvc                                     WARNING LVL1::eFEXOutputCollection/eFEXOutputCollection [LVL1::eFEXDriver/eFEXDriver]
StoreGateSvc                                     WARNING LVL1::jFEXOutputCollection/jFEXOutputCollection [LVL1::jFEXDriver/jFEXDriver]
StoreGateSvc                                     WARNING LVL1CTP::Lvl1Result/Lvl1Result [TrigDec::TrigDecisionMakerMT/TrigDecMakerMT]

fail trigger check_log. The specific cases shown above need to be fixed before this can be merged.

While direct SG access in new code should usually be picked up by review shifters, it's also possible for an algorithm to call a tool with direct SG access - no easy way to pick this up.

Edited Jan 10, 2022 by Stewart Martin-Haugh
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: check_for_direct_SG_access