Skip to content

ATLASRECTS-6523. Make the TrackingGeometryAlg not re-entrant and clean up uneeded/unused code that can also cause potential issues

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:ATLASRECTS-6523_make_non_renentrant_rm_unneeded_dangerous_code into master

ATLASRECTS-6523.

The TrackingGeometryAlg calls methods that are marked ATLAS_THREAD_NOT_SAFE so prb can not be re-entrant.

Also the code that shares ownership with the TrackingGeometry is unused and seems not to be 100% safe either so removed.

As an aside rm a couple of seemingly un-needed includes, and used new Gaudi style properties also for the relevant tool array

Running with (the command reported and discussed in the JIRA)

threads=8
export ATHENA_CORE_NUMBER=${threads}
rm -rf  DRAW_ZMUMU.data* .DRAW_ZMUMU.data* DESDM_MCP.pool.root  tmp.HIST_R2A
Reco_tf.py --skipEvents 1170 --maxEvents 6 --athenaopts='--exctrace'  \
   --inputBSFile=data15_13TeV.00276689.physics_Main.daq.RAW._lb0254._SFO-1._0001.data \
   --outputAODFile=AOD.pool.root \
   --outputHISTFile=HIST.root \
   --outputDESDM_MCPFile=DESDM_MCP.pool.root \
   --outputDRAW_ZMUMUFile=DRAW_ZMUMU.data \
   --outputDAOD_IDTIDEFile=DAOD_IDTIDE.pool.root \
   --multithreaded='True' \
   --preExec 'all:from AthenaMonitoring.DQMonFlags import DQMonFlags; DQMonFlags.doHLTMon=False' \
   --postExec 'FPEAuditor.NStacktracesOnFPE=500' \
   --autoConfiguration='everything' \
   --conditionsTag 'all:CONDBR2-BLKPA-RUN2-03' \
   --geometryVersion='default:ATLAS-R2-2016-01-00-01' \
   --runNumber='276689' \
   --steering='doRAWtoALL'

e.g over the problematic events

Examples : log_try1 log_try2

a few more in /afs/cern.ch/user/c/christos//public/ATLASRECTS-6523/

have not yet managed to see the crash with these changes.

pinging @sroe @goetz @elmsheus

Edited by Christos Anastopoulos

Merge request reports