Skip to content
Snippets Groups Projects

HLT jet reconstruction for heavy ion events in release 22

Merged Yeonju Go requested to merge ygo/athena:hihltjet_r22.0_wip into master

This MR is for heavy-ion style HLT jet reconstruction including CaloTower-based HICluster reconstruction and underlying event subtraction with Event Plane. Most part of the implementation have been performed in a new dedicated python file of 'TriggerMenuMT/HLTMenuConfig/Jet/JetHIConfig.py'. Please take a look, @valentem, @ayana and @mrybar. Thank you.

Edited by Yeonju Go

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marco Valente
  • Marco Valente
  • Hi @ygo, I just submitted a few minor comments. The modifications seem good to me, they should not break the pp chains. It would be good to let the CI run some tests and then see if they all pass, such that we can confirm that your modifications do not affect pp chains.

    A general question: I can't see any chain added to the HI dev menu. Is that expected? Did you check that the modifications you have made effectively allow you to run a HI chain without issues?

    Cheers -- Marco

  • I'll also let @khoo comment further in case he has some suggestions about the code. :)

    Marco

  • Yeonju Go added 1 commit

    added 1 commit

    • 62959cfe - removed redundant lines and added some comments as suggested by Marco

    Compare with previous version

  • Author Developer

    Hi @valentem, Thank you very much for reviewing the codes. I have addressed all your comments and made a new commit. For your question about the 'HI dev menu' I have checked that my modifications work well in running a HI chain without issues. I will discuss on the HI menu with HI conveners and update it in the next MR.

    Thank you, Yeonju Go

  • Yeonju Go added 1 commit

    added 1 commit

    • 3ce6f2eb - added heavy ion jet trigger paths in Dev_HI_run3_v1.py

    Compare with previous version

  • Author Developer

    Hi @valentem, I discussed with @mrybar and added jet trigger chains to the 'HI dev menu'. Please let me know if there is anything else needed further to unWIP.

    Thank you! Yeonju Go

  • Hi @ygo, thanks a lot. Please move ahead with the unWIP. :)

    Marco

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading