HLT jet reconstruction for heavy ion events in release 22
This MR is for heavy-ion style HLT jet reconstruction including CaloTower-based HICluster reconstruction and underlying event subtraction with Event Plane. Most part of the implementation have been performed in a new dedicated python file of 'TriggerMenuMT/HLTMenuConfig/Jet/JetHIConfig.py'. Please take a look, @valentem, @ayana and @mrybar. Thank you.
Merge request reports
Activity
Dear @ygo can you please add the atlas robot as a developer member of your fork? This way the CI results are properly communicated to us shifters. Thanks!
c.f. https://atlassoftwaredocs.web.cern.ch/gittutorial/gitlab-fork/#add-your-friendly-build-bot
-- L1
added 637 commits
- 1ab4a4eb...79ec0f26 - 627 commits from branch
atlas:master
- ca5118a0 - made heavy ion jet sequence: simple copy of pp jet sequence
- 8af1599e - work-in-progress for HI HLT jet reconstruction
- f5aeed62 - work-in-progress 2 for HI HLT jet reconstruction
- 7da67080 - implemented HI HLT jet recontruction (without UE subtraction)
- 22fef322 - work-in-progress 4: HIEventShape implemented
- f6a263e4 - temp commit
- 0cc040cb - happy
- a1b0d3c6 - very happy :) now it is working!!!
- 03201aa0 - Draft: HLT jet reconsturction for heavy-ion events in release 22
- 7c647173 - fixed a conflict in JetRecoConfiguration.py
Toggle commit list- 1ab4a4eb...79ec0f26 - 627 commits from branch
- Resolved by Marco Valente
- Resolved by Yeonju Go
- Resolved by Marco Valente
- Resolved by Marco Valente
Hi @ygo, I just submitted a few minor comments. The modifications seem good to me, they should not break the pp chains. It would be good to let the CI run some tests and then see if they all pass, such that we can confirm that your modifications do not affect pp chains.
A general question: I can't see any chain added to the HI dev menu. Is that expected? Did you check that the modifications you have made effectively allow you to run a HI chain without issues?
Cheers -- Marco
I'll also let @khoo comment further in case he has some suggestions about the code. :)
Marco
added 1 commit
- 62959cfe - removed redundant lines and added some comments as suggested by Marco
Hi @valentem, Thank you very much for reviewing the codes. I have addressed all your comments and made a new commit. For your question about the 'HI dev menu' I have checked that my modifications work well in running a HI chain without issues. I will discuss on the HI menu with HI conveners and update it in the next MR.
Thank you, Yeonju Go
added 1 commit
- 3ce6f2eb - added heavy ion jet trigger paths in Dev_HI_run3_v1.py
Hi @ygo, thanks a lot. Please move ahead with the unWIP. :)
Marco