Skip to content

Bug fix in ElectronPhotonVariableCorrection: Use wrong vector to calculate largest bin number in findBin()

Nils Gillwald requested to merge nigillwa/athena:eyVarCorr_bugfix_findBin_wrongVectorUsed_21.2 into 21.2

In the ElectronPhotonVariableCorrectionTool located in the ElectronPhotonShowerShapeFudgeTool package, the findBin() function is supposed to return the correct bin of the correction to use for all binned correction types. It checks if the value lies in the first given bin, then the second, etc. If it does not lie in any of the given bins, then it must be in the "overflow" bin going up to "infinity". The calculation of the overflow bin number is done incorrectly, since the wrong vector is used: The vector saving all vectors with binned correction values, instead of the vector saving the currently used binning. This MR updates the code so it uses the correct vector for the calculation.

The same bug is corrected for master in !45688 (merged).

Edited by Nils Gillwald

Merge request reports