Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 160
    • Merge requests 160
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !45780

FATRAS: fix TRT building in complex geometry mode

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Liza Mijovic requested to merge lmijovic/athena:master_TRTlayer_fix into master Aug 13, 2021
  • Overview 5
  • Commits 1
  • Pipelines 1
  • Changes 2

This is a bug-fix for TRT material layer building in FATRAS. The code should build a number of material layers (m_modelBarrelLayers) from a larger number of straw layers (nTotalBarrelLayers). It however uses a too large step (nMaterialLayerStep). Therefore an incorrect number of material layers is built.

The fix provides the correct step size, for each of TRT barrel and TRT endcaps, and issues a WARNING in case of the incorrect number of material layers.

Fix and implications were discussed at the Fast Chain meeting. The p5 of the linked slides shows a numerical example of why the original step was too large, p6 a numerical example of the fix. The bug only affects the TRT tracking geometry building for FATRAS. The TRT tracking geometry of reconstruction geometry is not affected, as this does not use the complex geometry fixed here.

@golling @pagacova @tcuhadar @jchapman

Edited Aug 13, 2021 by Liza Mijovic
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master_TRTlayer_fix