Skip to content

Skip leg IDs in TrigSteerMoni, only count DecisionObjects flagged with chain IDs

This is meant to avoid multiple-counting of features (filling the feature decision histogram 1x for each leg to which the feature could contribute).

The changes are to:

  1. Provide only ComboHypo outputs to TrigSteerMoni as the decision objects to count
  2. TrigSteerMoni should ignore leg IDs in its input decision objects (in practice this check is probably made redundant by the change above)
  3. As a new option (ConfigFlags.Trigger.doPerLegFeatureCounts), enable the logging of leg IDs for every component leg of a chain. Features passing a leg are logged even if the chain decision for a step is negative.

Expected impact on the reference counts:

  • No features for steps that fail (previously would count features passing legs)
  • Counts for multi-leg chains should typically be reduced because multiple-counting is eliminated, in addition to the removal of passing leg features from events in which the chain fails.
  • Feature count increases typically occur because empty steps used for alignment result in the L1 RoIs being flagged as features and added to the chain feature count.

Likely to conflict with any other menu changes.

Updated to include solution for ATR-24954.

Edited by Teng Jian Khoo

Merge request reports