Skip to content

add likely branch hints for status code checks in AnalysisBase

Nils Erik Krumnack requested to merge krumnack/athena:check_expect into master

Honestly I didn't really check how much difference this makes, but it ought to be safe and not hurt anything. Essentially I only marked non-recoverable failures and initialization on first use as unlikely.

Running the CP algorithm unit tests on my machine this maybe saves a second over a two minute runtime, but honestly that may be below the noise level I can achieve for such measurements. I'm not really setup to do performance tests at that level, and those unit tests may not be fully representative of typical analysis jobs anyways. But as I said, I don't believe this would hurt anything.

Mostly a bit hesitant here because the main ATH_CHECK macro in full Athena doesn't use this. Presumably if it made a difference someone in SPOT would have checked and enabled this. @amete do you have an opinion or experience with this?

@cohm this is what I was talking about earlier.

Merge request reports