Skip to content

ATLASRECTS-6562. Remove the setLayerType , not thread safe const overload that was hiding a const_cast.

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:ATLASRECTS-6562_Part_II into master

ATLASRECTS-6562.

  • Remove the setLayerType , not thread safe const overload that was performing a const_cast on this

  • Do the const_cast explicitly at the code that needs them so as the exact code locations neededing attention to be obvious and we can properly see them / count them rahter than being hidden .

  • In the client code remove already some obviously un-needed const that were leading to using the non thread safe overload so at reduce the overall number of const_cast actually happening.

  • Do some run clang-tidy related fixes (2nd commit)

  • We will need another refactor round to remove the rest e.g not sure still if some of the places need to be const or is unneeded . But now should be visible where and why the const_cast occur rather than being hidden.

Mentioning @sroe

Edited by Christos Anastopoulos

Merge request reports