Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 192
    • Merge requests 192
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !46136

Closed
Created Aug 27, 2021 by Mark Sutton@suttDeveloper
  • Report abuse
Report abuse

Revert changesto the TrigInDetAnalysisUser from !45989 which broke the code

  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 13

Some change added to the the standalone executable code seem to have broken the code in this package - see ATR-24075

This in turn broke the ID Trigger nightly tests.

As ever this package only builds standalone executables which, as I never tire of saying, are not tested in any way by the CI tests, which do not even run this code.

As such, this problem was not spotted by the CI, demonstrating just what a waste of time they are for changes to this particular package, since there is no athena code which depends on them - they are used essentially only for the ID Trigger ART tests.

Since the nightly tests are failing, then rather than go through one by one trying to identify specifically which change broke the code, it has simply been reverted it to how it was before so that we can get the tests working again more quickly

Edited Aug 27, 2021 by Mark Sutton
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: rp