Adding support for Leading3SignalJets strategy
- Adding support for
Leading3SignalJets
strategy for Truth Tagging with GNN - strategy is implemented in a more generalized way. It Will help in gaining a bit of speed as well
- Removed a few unnecessary conditional statements.
- bugfix - GNN returns efficiencies in 5 bins. We want to keep only 4 (the bin 100%-85% is not needed for the later stages)
Merge request reports
Activity
- Resolved by Louis-Guillaume Gagnon
Hi Nilotpal,
I was thinking: instead of doing so many string comparisons, why don't we create an enum with {AllJets, Leading2 and Leading3} and we convert the string into an enum when we set the Property? In this way we will compare numbers instead of strings and we should gain a bit in speed.
added 1 commit
- 14ba4259 - comparing enums for strategy instead of strings
- Resolved by Louis-Guillaume Gagnon
Hi Nilotpal, it looks much better to me and I think we can remove the draft status. (Nilotpal, have you quickly tested it, right?)
This merge request affects 1 package:
- PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency
This merge request affects 2 files:
- PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency/Root/BTaggingTruthTaggingTool.cxx
- PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency/xAODBTaggingEfficiency/BTaggingTruthTaggingTool.h
CI Result SUCCESS (hash a1a763bf)AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39209] CI Result SUCCESS (hash a1a763bf)AthDerivation externals cmake make required tests optional tests Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-GCC62-CC7 1042]added review-approved label and removed review-pending-level-1 label
Hi @boeriu,
Sorry for being a bit behind on my reviews. This is fine, and analysis-review-required is only used in master.
Cheers, Nils
mentioned in commit b49eb2f8
added sweep:ignore label