Skip to content
Snippets Groups Projects

TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet

Merged Claire Antel requested to merge cantel/athena:master-configure-jetcoll into master

ATR-22333

Purpose

Currently the b-tag related output containers are named the same irrespective of which jet collection they were produced from. We want output containers named based on the full jet collection name. This MR implements this in two steps:

  • (a) Jet changes: Function to retrieve full jet container name from jet chain dictionary.
  • (b) Bjet changes: Use of full jet container name in output collection names.

Basically

  • Old container name: HLT_bJets
  • New container name: HLT_AntiKt4EMPFlowJets_subresjesgscIS_ftf_bJets

Also

  • Old container name: HLT_BTagging
  • New container name: HLT_AntiKt4EMPFlowJets_subresjesgscIS_ftf_BTagging

etc.

Details

Jet changes

Function to retrieve the full jet container implemented in TriggerMenuMT/JetChainConfiguration.py . Uses as far as possible pre-existing functions to assemble jet name. Jet name retrieved via so

        jet_cfg = JetChainConfiguration(chainDict)
        jet_name = jet_cfg.jetName

Bjet changes

  • GenerateBjetChainDefs calls jet_cfg.jetName function to retrieve and pass jet collection name through to bjet slice.
  • BjetChainConfiguration, BjetMenuSequences, BjetFlavourTaggingConfiguration adapted to use new jet name structure.
  • TriggerEDMRun3 updated.
  • Conditions DB alias update in runHLT_standalone.py

This affects...

  • Affects TriggerMenuMT Jet and Bjet python configuration files.
  • Affects TrigEDMConfig: Adds new b-tag collections (EMTopo & PFlow based), removes old ones.
  • Adaptations needed in b-jet monitoring and derivation framework.

Tests run

runHLT_standalone.py

athena.py -l INFO -c "setMenu='LS2_v1'; forceEnableAllChains=True;doEmptyMenu=True;doBjetSlice=True;doWriteBS=True;doWriteRDOTrigger=False;" --imf --perfmon --threads=1 --evtMax=10 --filesInput=/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/TriggerTest/valid1.410000.PowhegPythiaEvtGen_P2012_ttbar_hdamp172p5_nonallhad.merge.RDO.e4993_s3214_r11315/RDO.17533168._000001.pool.root.1 TriggerJobOpts/runHLT_standalone.py
athena.py -l INFO -c "setMenu='Cosmic_run3_v1'; forceEnableAllChains=True;doEmptyMenu=True;doBjetSlice=True;doWriteBS=True;doWriteRDOTrigger=False;" --imf --perfmon --threads=1 --evtMax=10 --filesInput=/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/TriggerTest/valid1.410000.PowhegPythiaEvtGen_P2012_ttbar_hdamp172p5_nonallhad.merge.RDO.e4993_s3214_r11315/RDO.17533168._000001.pool.root.1 TriggerJobOpts/runHLT_standalone.py
athena.py -l INFO -c "setMenu='LS2_v1'; forceEnableAllChains=True;doEmptyMenu=True;doWriteBS=True;doWriteRDOTrigger=False;" --imf --perfmon --threads=1 --evtMax=10 --filesInput=/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/TriggerTest/valid1.410000.PowhegPythiaEvtGen_P2012_ttbar_hdamp172p5_nonallhad.merge.RDO.e4993_s3214_r11315/RDO.17533168._000001.pool.root.1 TriggerJobOpts/runHLT_standalone.py

minimal runTrigART.py

runTrigART.py -m -j4

Only WARNINGS (not linked to my changes in any obvious way).

ctests: All pass

Edited by Claire Antel

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jenkins please retry a build

  • This merge request affects 3 packages:

    • Trigger/TriggerCommon/TrigEDMConfig
    • Trigger/TriggerCommon/TriggerJobOpts
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@hrussell ,@okuprash ,@suyogs ,@sekula ,@dzanzi ,@bernius as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash 35ec3648)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39024]

  • Claire Antel added 697 commits

    added 697 commits

    • 35ec3648...f33be002 - 695 commits from branch atlas:master
    • 68d4444e - Merge remote-tracking branch 'upstream/master' into master-configure-jetcoll
    • 86089359 - code clean up and remove irrelavant alias.

    Compare with previous version

  • Author Developer

    Hi @enagy,

    Nothing in the tests failed due to the monitoring as far as I can tell. I see HLT_bJets used in TrigBJetMonitoring though.

    https://acode-browser1.usatlas.bnl.gov/lxr/search?%21v=head&_filestring=&_string=HLT_bJets

    Maybe you can have a look anyways.

  • Claire Antel added 1 commit

    added 1 commit

    • 504f592c - BjetMenuSequence exception in case of empty jet collection name argument

    Compare with previous version

  • Claire Antel marked this merge request as ready

    marked this merge request as ready

  • Claire Antel changed the description

    changed the description

  • This merge request affects 3 packages:

    • Trigger/TriggerCommon/TrigEDMConfig
    • Trigger/TriggerCommon/TriggerJobOpts
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@hrussell ,@okuprash ,@suyogs ,@sekula ,@dzanzi ,@bernius as watchers

  • Author Developer

    As far as I can tell, currently some tests fail because:

    (1) Cosmic_run3_v1 only runs non-pflow chains, but EMTopo b-jet containers are not added tin TriggerEDMRun3, as LS2_v1 only runs pflow chains. I am not sure if I am supposed to address that (and how). Gap filler seems to work now locally for me too. Have added the b-jet EMTopo jets to the EDM.

    (2) TriggerMenuMT_full_menu_cf_ctest fails because it sets an empty jet collection name. Again, not sure whether I need to address that and fix generateCFChains as this folder isn't checked out when checking out the TriggerMenuMT package. Nevermind, stupid oversight from my side. ctest is fixed.

    Edited by Claire Antel
  • Claire Antel marked this merge request as draft

    marked this merge request as draft

  • :negative_squared_cross_mark: CI Result FAILURE (hash 504f592c)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39100]

  • Claire Antel changed the description

    changed the description

  • Claire Antel added 2 commits

    added 2 commits

    • 8a529724 - TrigEDM adding EMTopo b-jets for other menus - gap filler supposed to work for...
    • c0f1b10a - TrigMenuMT Jet adding comment on clustersKey retrieval

    Compare with previous version

  • Author Developer

    Jenkins please retry a build

  • This merge request affects 3 packages:

    • Trigger/TriggerCommon/TrigEDMConfig
    • Trigger/TriggerCommon/TriggerJobOpts
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@hrussell ,@okuprash ,@suyogs ,@sekula ,@dzanzi ,@bernius as watchers

  • Claire Antel added 144 commits

    added 144 commits

    • c0f1b10a...6856b7cc - 142 commits from branch atlas:master
    • 740092b5 - Merge remote-tracking branch 'upstream/master' into master-configure-jetcoll
    • 038d823a - fixing CF ctest

    Compare with previous version

  • :negative_squared_cross_mark: CI Result FAILURE (hash c0f1b10a)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39139]

  • Author Developer

    Jenkins please retry a build

  • This merge request affects 3 packages:

    • Trigger/TriggerCommon/TrigEDMConfig
    • Trigger/TriggerCommon/TriggerJobOpts
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@hrussell ,@okuprash ,@suyogs ,@sekula ,@dzanzi ,@bernius as watchers

  • Claire Antel added 1 commit

    added 1 commit

    • 24861632 - TrigJobOpt aaaargh forgot to add bjet EMTopo alias, ran wrong test earlier

    Compare with previous version

  • :negative_squared_cross_mark: CI Result FAILURE (hash 038d823a)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39160]

  • Author Developer

    Jenkins please retry a build

  • This merge request affects 3 packages:

    • Trigger/TriggerCommon/TrigEDMConfig
    • Trigger/TriggerCommon/TriggerJobOpts
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@hrussell ,@okuprash ,@suyogs ,@sekula ,@dzanzi ,@bernius as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash 24861632)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39193]

  • Claire Antel added 419 commits

    added 419 commits

    • 24861632...62611340 - 417 commits from branch atlas:master
    • ed5141a6 - Merge remote-tracking branch 'upstream/master' into master-configure-jetcoll
    • 53825ff4 - TrigMenuMT Appending jc name to bjet view, hypo and sequence names

    Compare with previous version

  • Author Developer

    Jenkins please retry a build

  • This merge request affects 3 packages:

    • Trigger/TriggerCommon/TrigEDMConfig
    • Trigger/TriggerCommon/TriggerJobOpts
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@hrussell ,@okuprash ,@suyogs ,@sekula ,@dzanzi ,@bernius as watchers

  • Claire Antel changed the description

    changed the description

  • :negative_squared_cross_mark: CI Result FAILURE (hash 53825ff4)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39617]

  • Claire Antel added 1 commit

    added 1 commit

    • 8f9ad68b - TrigMenuMT fixing compiler warnings

    Compare with previous version

  • Author Developer

    To note: There were python "compiler" warnings which I've fixed.

    The failures on required tests don't appear related to my changed

    AttributeError: module 'GaudiConfig2.Configurables' has no attribute 'LArAlignCondAlg'

    is this expected?

  • Claire Antel added 307 commits

    added 307 commits

    • 8f9ad68b...272d5aa7 - 305 commits from branch atlas:master
    • 8808a8bf - TMMT Jet adding getClustersKey to JetRecoConfiguration for direct retrieval of...
    • fe5a8352 - Merge remote-tracking branch 'upstream/master' into master-configure-jetcoll

    Compare with previous version

  • Claire Antel marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 3 packages:

    • Trigger/TriggerCommon/TrigEDMConfig
    • Trigger/TriggerCommon/TriggerJobOpts
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@hrussell ,@okuprash ,@suyogs ,@sekula ,@dzanzi ,@bernius as watchers

  • Claire Antel changed title from TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet to TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet{+ (https://its.cern.ch/jira/browse/ATR-22333)+}

    changed title from TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet to TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet{+ (https://its.cern.ch/jira/browse/ATR-22333)+}

  • Claire Antel changed title from TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet (https://its.cern.ch/jira/browse/ATR-22333) to TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet ([ATR-22333](https://its.cern.ch/jira/browse/ATR-22333))

    changed title from TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet (https://its.cern.ch/jira/browse/ATR-22333) to TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet ([ATR-22333](https://its.cern.ch/jira/browse/ATR-22333))

  • Claire Antel changed title from TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet{- (ATR-22333)-} to TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet

    changed title from TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet{- (ATR-22333)-} to TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet

  • Claire Antel changed the description

    changed the description

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading