TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet
Purpose
Currently the b-tag related output containers are named the same irrespective of which jet collection they were produced from. We want output containers named based on the full jet collection name. This MR implements this in two steps:
- (a) Jet changes: Function to retrieve full jet container name from jet chain dictionary.
- (b) Bjet changes: Use of full jet container name in output collection names.
Basically
- Old container name:
HLT_bJets
- New container name:
HLT_AntiKt4EMPFlowJets_subresjesgscIS_ftf_bJets
Also
- Old container name:
HLT_BTagging
- New container name:
HLT_AntiKt4EMPFlowJets_subresjesgscIS_ftf_BTagging
etc.
Details
Jet changes
Function to retrieve the full jet container implemented in TriggerMenuMT/JetChainConfiguration.py
. Uses as far as possible pre-existing functions to assemble jet name. Jet name retrieved via so
jet_cfg = JetChainConfiguration(chainDict)
jet_name = jet_cfg.jetName
Bjet changes
-
GenerateBjetChainDefs
callsjet_cfg.jetName
function to retrieve and pass jet collection name through to bjet slice. -
BjetChainConfiguration
,BjetMenuSequences
,BjetFlavourTaggingConfiguration
adapted to use new jet name structure. -
TriggerEDMRun3
updated. - Conditions DB alias update in
runHLT_standalone.py
This affects...
- Affects
TriggerMenuMT
Jet and Bjet python configuration files. - Affects
TrigEDMConfig
: Adds new b-tag collections (EMTopo & PFlow based), removes old ones. - Adaptations needed in b-jet monitoring and derivation framework.
Tests run
runHLT_standalone.py
athena.py -l INFO -c "setMenu='LS2_v1'; forceEnableAllChains=True;doEmptyMenu=True;doBjetSlice=True;doWriteBS=True;doWriteRDOTrigger=False;" --imf --perfmon --threads=1 --evtMax=10 --filesInput=/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/TriggerTest/valid1.410000.PowhegPythiaEvtGen_P2012_ttbar_hdamp172p5_nonallhad.merge.RDO.e4993_s3214_r11315/RDO.17533168._000001.pool.root.1 TriggerJobOpts/runHLT_standalone.py
athena.py -l INFO -c "setMenu='Cosmic_run3_v1'; forceEnableAllChains=True;doEmptyMenu=True;doBjetSlice=True;doWriteBS=True;doWriteRDOTrigger=False;" --imf --perfmon --threads=1 --evtMax=10 --filesInput=/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/TriggerTest/valid1.410000.PowhegPythiaEvtGen_P2012_ttbar_hdamp172p5_nonallhad.merge.RDO.e4993_s3214_r11315/RDO.17533168._000001.pool.root.1 TriggerJobOpts/runHLT_standalone.py
athena.py -l INFO -c "setMenu='LS2_v1'; forceEnableAllChains=True;doEmptyMenu=True;doWriteBS=True;doWriteRDOTrigger=False;" --imf --perfmon --threads=1 --evtMax=10 --filesInput=/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/TriggerTest/valid1.410000.PowhegPythiaEvtGen_P2012_ttbar_hdamp172p5_nonallhad.merge.RDO.e4993_s3214_r11315/RDO.17533168._000001.pool.root.1 TriggerJobOpts/runHLT_standalone.py
minimal runTrigART.py
runTrigART.py -m -j4
Only WARNINGS (not linked to my changes in any obvious way).
ctests
: All pass
Merge request reports
Activity
added BJetTrigger TriggerEDM TriggerJet master labels
- Resolved by Claire Antel
added full-unit-tests label
added BTagging JetEtmiss Trigger TriggerMenu labels
CI Result FAILURE (hash 35ec3648)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39024]added 697 commits
-
35ec3648...f33be002 - 695 commits from branch
atlas:master
- 68d4444e - Merge remote-tracking branch 'upstream/master' into master-configure-jetcoll
- 86089359 - code clean up and remove irrelavant alias.
-
35ec3648...f33be002 - 695 commits from branch
Hi @enagy,
Nothing in the tests failed due to the monitoring as far as I can tell. I see
HLT_bJets
used in TrigBJetMonitoring though.https://acode-browser1.usatlas.bnl.gov/lxr/search?%21v=head&_filestring=&_string=HLT_bJets
Maybe you can have a look anyways.
added 1 commit
- 504f592c - BjetMenuSequence exception in case of empty jet collection name argument
added review-pending-level-1 label
As far as I can tell, currently some tests fail because:
(1)
Gap filler seems to work now locally for me too. Have added the b-jet EMTopo jets to the EDM.Cosmic_run3_v1
only runs non-pflow chains, but EMTopo b-jet containers are not added tin TriggerEDMRun3, asLS2_v1
only runs pflow chains. I am not sure if I am supposed to address that (and how).(2)
Nevermind, stupid oversight from my side. ctest is fixed.TriggerMenuMT_full_menu_cf_ctest
fails because it sets an empty jet collection name. Again, not sure whether I need to address that and fixgenerateCFChains
as this folder isn't checked out when checking out the TriggerMenuMT package.Edited by Claire Antel- Resolved by Frank Winklmeier
Hi @cantel, I suggest that you run an ART test yourself before requesting an MR to see if it'll break again.
CI Result FAILURE (hash 504f592c)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39100]removed review-pending-level-1 label
added 144 commits
-
c0f1b10a...6856b7cc - 142 commits from branch
atlas:master
- 740092b5 - Merge remote-tracking branch 'upstream/master' into master-configure-jetcoll
- 038d823a - fixing CF ctest
-
c0f1b10a...6856b7cc - 142 commits from branch
CI Result FAILURE (hash c0f1b10a)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39139]added 1 commit
- 24861632 - TrigJobOpt aaaargh forgot to add bjet EMTopo alias, ran wrong test earlier
CI Result FAILURE (hash 038d823a)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39160] CI Result FAILURE (hash 24861632)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39193]added 419 commits
-
24861632...62611340 - 417 commits from branch
atlas:master
- ed5141a6 - Merge remote-tracking branch 'upstream/master' into master-configure-jetcoll
- 53825ff4 - TrigMenuMT Appending jc name to bjet view, hypo and sequence names
-
24861632...62611340 - 417 commits from branch
CI Result FAILURE (hash 53825ff4)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39617]added 307 commits
-
8f9ad68b...272d5aa7 - 305 commits from branch
atlas:master
- 8808a8bf - TMMT Jet adding getClustersKey to JetRecoConfiguration for direct retrieval of...
- fe5a8352 - Merge remote-tracking branch 'upstream/master' into master-configure-jetcoll
-
8f9ad68b...272d5aa7 - 305 commits from branch
added review-pending-level-1 label
changed title from TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet to TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet{+ (https://its.cern.ch/jira/browse/ATR-22333)+}
changed title from TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet (https://its.cern.ch/jira/browse/ATR-22333) to TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet ([ATR-22333](https://its.cern.ch/jira/browse/ATR-22333))
changed title from TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet{- (ATR-22333)-} to TriggerMenuMT Retrieve & use HLT jet collection name in HLT Bjet