Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 181
    • Merge requests 181
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !46577

Updating setting of isolation variables working points due to use of firmware thresholds

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Antonio Manuel Mendes Jacques Da Costa requested to merge amendesj/athena:master-workingPointsFix into master Sep 17, 2021
  • Overview 6
  • Commits 1
  • Pipelines 1
  • Changes 5

Firmware threshold values are being used when setting the working points for the isolation variables (Reta, Rhad and Wstot).

Example here: getting fw thrs and firmware threshold values set here: setting of fw thrs

This required changes in how the comparisons in the setting of the working points are done, namely introducing a bitshift factor.

In addition a fix of the Wstot output (necessary for setting the WPs) was implemented.

The trigger counts in the reference file are updated as well, following discussion in Previous MR

@afaulkne

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-workingPointsFix