GeneratorObjectsTPCnv: Clear flow information when reading.
For versions p2, p3, and p4, we weren't clearing flow information before filling it. Since these objects are managed by a DataPool, than means that the flow information is garbage when we read these versions. Fixed.
See ATLASSIM-5403.
Merge request reports
Activity
This merge request affects 1 package:
- Generators/GeneratorObjectsTPCnv
This merge request affects 3 files:
- Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p2.cxx
- Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p3.cxx
- Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p4.cxx
added Generators master review-pending-level-1 labels
- Resolved by Tadej Novak
Should fix a bug where HepMC flow information is read incorrectly from GenEvent versions _p2, _p3, and _p4 (_p5 should be ok). As such, this may change the output of jobs reading such HepMC data.
John @jchapman, maybe this should be swept to the release branches?
CI Result SUCCESS (hash a8bd69cf)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39231]added review-pending-level-2 label and removed review-pending-level-1 label
added review-approved label and removed review-pending-level-2 label
mentioned in commit 5c99a242
added sweep:done label
picked the changes into the branch
cherry-pick-5c99a242baf-22.0-mc20
with commit b77478a6mentioned in commit b77478a6
mentioned in merge request !46611 (merged)
picked the changes into the branch
cherry-pick-5c99a242baf-21.6
with commit 82a19937mentioned in commit 82a19937
mentioned in merge request !46612 (merged)
picked the changes into the branch
cherry-pick-5c99a242baf-21.9
with commit bd3c5eafmentioned in commit bd3c5eaf
picked the changes into the branch
cherry-pick-5c99a242baf-21.0
with commit 12de4a54mentioned in commit 12de4a54
mentioned in merge request !46613 (merged)
Sweep summary
successful:- 21.0
- 21.6
- 21.9
- 22.0-mc20
(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/1684/console for details)
mentioned in merge request !46614 (merged)
mentioned in commit 9def9700
mentioned in commit b667267e
mentioned in commit fd1469cd
mentioned in commit ff91b6e1