Moderinzation of LArRTMParamExtractor algorithm
Avoid potential memory leaks by using std::unique_ptr and std::optional as needed.
Merge request reports
Activity
This merge request affects 1 package:
- LArCalorimeter/LArCalibUtils
This merge request affects 2 files:
- LArCalorimeter/LArCalibUtils/LArCalibUtils/LArRTMParamExtractor.h
- LArCalorimeter/LArCalibUtils/src/LArRTMParamExtractor.cxx
Adding @pavol as watcher
added JetEtmiss LAr master review-pending-level-1 labels
CI Result SUCCESS (hash f4bfcba6)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39415]- Resolved by Walter Lampl
added review-user-action-required label and removed review-pending-level-1 label
This merge request affects 1 package:
- LArCalorimeter/LArCalibUtils
This merge request affects 5 files:
- LArCalorimeter/LArCalibUtils/LArCalibUtils/LArRTMParamExtractor.h
- LArCalorimeter/LArCalibUtils/LArCalibUtils/LArWFParamTool.h
- LArCalorimeter/LArCalibUtils/src/LArDeltaRespPredictor.cxx
- LArCalorimeter/LArCalibUtils/src/LArRTMParamExtractor.cxx
- LArCalorimeter/LArCalibUtils/src/LArWFParamTool.cxx
Adding @pavol as watcher
added review-pending-level-1 label and removed review-user-action-required label
added 1 commit
- b6cea70f - remove commented code-lines in LArRTMParamExtractor.cxx
This merge request affects 1 package:
- LArCalorimeter/LArCalibUtils
This merge request affects 5 files:
- LArCalorimeter/LArCalibUtils/LArCalibUtils/LArRTMParamExtractor.h
- LArCalorimeter/LArCalibUtils/LArCalibUtils/LArWFParamTool.h
- LArCalorimeter/LArCalibUtils/src/LArDeltaRespPredictor.cxx
- LArCalorimeter/LArCalibUtils/src/LArRTMParamExtractor.cxx
- LArCalorimeter/LArCalibUtils/src/LArWFParamTool.cxx
Adding @pavol as watcher
CI Result SUCCESS (hash 4a070302)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39431] CI Result SUCCESS (hash b6cea70f)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39432]added review-approved label and removed review-pending-level-1 label
mentioned in commit 86dcb682
added sweep:ignore label