Skip to content
Snippets Groups Projects

Moderinzation of LArRTMParamExtractor algorithm

Merged Walter Lampl requested to merge wlampl/athena:LArRTMParamsExtractorUP into master
All threads resolved!

Avoid potential memory leaks by using std::unique_ptr and std::optional as needed.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Walter Lampl added 2 commits

    added 2 commits

    • 6379b713 - systematically use std::optional in all clients of the LArWFParamTool
    • 4a070302 - remove unnecessary include statements in LArRTMParamExtractor.cxx

    Compare with previous version

  • This merge request affects 1 package:

    • LArCalorimeter/LArCalibUtils

    This merge request affects 5 files:

    • LArCalorimeter/LArCalibUtils/LArCalibUtils/LArRTMParamExtractor.h
    • LArCalorimeter/LArCalibUtils/LArCalibUtils/LArWFParamTool.h
    • LArCalorimeter/LArCalibUtils/src/LArDeltaRespPredictor.cxx
    • LArCalorimeter/LArCalibUtils/src/LArRTMParamExtractor.cxx
    • LArCalorimeter/LArCalibUtils/src/LArWFParamTool.cxx

    Adding @pavol as watcher

  • Walter Lampl added 1 commit

    added 1 commit

    • b6cea70f - remove commented code-lines in LArRTMParamExtractor.cxx

    Compare with previous version

  • Walter Lampl resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • LArCalorimeter/LArCalibUtils

    This merge request affects 5 files:

    • LArCalorimeter/LArCalibUtils/LArCalibUtils/LArRTMParamExtractor.h
    • LArCalorimeter/LArCalibUtils/LArCalibUtils/LArWFParamTool.h
    • LArCalorimeter/LArCalibUtils/src/LArDeltaRespPredictor.cxx
    • LArCalorimeter/LArCalibUtils/src/LArRTMParamExtractor.cxx
    • LArCalorimeter/LArCalibUtils/src/LArWFParamTool.cxx

    Adding @pavol as watcher

  • :white_check_mark: CI Result SUCCESS (hash 4a070302)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39431]

  • :white_check_mark: CI Result SUCCESS (hash b6cea70f)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39432]

  • Edward Moyse mentioned in commit 86dcb682

    mentioned in commit 86dcb682

  • merged

  • Please register or sign in to reply
    Loading