Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 143
    • Merge requests 143
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !46713

urgent fix of tob scale for the eFEX taus

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Alison Elliot requested to merge afaulkne/athena:master-fixTauScale into master Sep 24, 2021
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 3

As pointed out by @asonay , there were no Tau TOBs passing to L1Topo. This was found to be due to a recent change to use the internal firmware energy scale for calculations in the algorithms. This was not factored into the Taus, meaning their et values were 25x too small. With this merge, this has been fixed.

Additionally, as suggested by @jburr , the scaling was moved into the formTOBs classes, where the tob and xtob scales are stored in the headers.

This is an urgent fix, as the taus are needed for ongoing developments of the combined taus in L1Topo. @dzanzi .

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-fixTauScale