Skip to content
Snippets Groups Projects

Defer preloads evaluation to the execution time

Merged Tadej Novak requested to merge tadej/athena:trf/preload into 22.0-mc20
All threads resolved!

An attempt to fix ATLASJT-422. This defers preloads evaluation to the execution time in the runwrapper. This seemingly loads the correct libraries when using inline asetup.

For reference, this is how runwrapper looks now:

athena.py --preloadlib=$ATLASMKLLIBDIR_PRELOAD/libimf.so:$ATLASMKLLIBDIR_PRELOAD/libintlc.so.5 --drop-and-reload runargs.RDOtoRDOTrigger.py RecJobTransforms/skeleton.RDOtoRDOtrigger.py

/cc @amete, @akraszna

Edited by Tadej Novak

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added bugfix label

  • This merge request affects 1 package:

    • Tools/PyJobTransforms

    This merge request affects 1 file:

    • Tools/PyJobTransforms/python/trfEnv.py
  • @tadej: The logs should have lines like these:

    Preloading tcmalloc_minimal.so
    Preloading /cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/2021-09-23T2101/AthenaExternals/22.0.45/InstallArea/x86_64-centos7-gcc8-opt/lib/libintlc.so.5:/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/2021-09-23T2101/AthenaExternals/22.0.45/InstallArea/x86_64-centos7-gcc8-opt/lib/libimf.so

    In addition, if you're running an MT reconstruction job, PerfMonMTSvc will also print some relevant information at the end of the job:

    INFO Malloc Library:                    libtcmalloc_minimal.so
    INFO Math Library:                      libimf.so
    • Author Developer
      Resolved by Tadej Novak

      Hmm, with trigger, I do not get this printout neither before nor after my change. I only see Preloading tcmalloc_minimal.so.

      Edit: this is from the overlay step running in R22:

      Overlay 11:05:27 Mon Sep 27 11:05:27 CEST 2021
      Overlay 11:05:27 Preloading tcmalloc_minimal.so
      Overlay 11:05:27 Preloading /cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/2021-09-13T2101/AthenaExternals/22.0.44/InstallArea/x86_64-centos7-gcc8-opt/lib/libintlc.so.5:/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/2021-09-13T2101/AthenaExternals/22.0.44/InstallArea/x86_64-centos7-gcc8-opt/lib/libimf.so
      Edited by Tadej Novak
  • Attila Krasznahorkay
  • Tadej Novak changed the description

    changed the description

  • Tadej Novak resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 7495faf1)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39495]

  • Looks good. Approved

    Sergei L1

  • mentioned in commit a07a3c0b

  • Atlas Nightlybuild picked the changes into the branch cherry-pick-a07a3c0bf98-master with commit 15ead4c8

    picked the changes into the branch cherry-pick-a07a3c0bf98-master with commit 15ead4c8

  • mentioned in commit 15ead4c8

  • Atlas Nightlybuild mentioned in merge request !46787 (merged)

    mentioned in merge request !46787 (merged)

  • mentioned in commit def9b716

  • Please register or sign in to reply
    Loading