Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 160
    • Merge requests 160
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !46772

Refactor of MdtCalibFramework - Vol I

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Johannes Junggeburth requested to merge jojungge/athena:calib_framework into master Sep 28, 2021
  • Overview 24
  • Commits 107
  • Pipelines 0
  • Changes 350

Hi,

this is the first big MR of the series to clean up the MdtCalibrationFramework. In summary, the MR comprises the following changes:

  • Abandon constructors with gazillions of arguments. Instead, instantiate helper structs which members are unambiguously instantiated
  • Avoid the usage of bare pointers in the context of the creation of objects and classes
  • Enforce the interface concepts for the IAlgTools
  • Remove a bunch of inline statements which are totally unnecessary
  • Use ReadHandleKeys to declare the data dependencies
  • Breakout the calibration N-tuple format towards the MdtCalibFramework

C.C: @rdinardo, @diehl

Edited Sep 30, 2021 by Johannes Junggeburth
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: calib_framework