Switched CaloCalibHitRec to getting CaloDetDescrManager from the Condition Store
This is part of the ongoing migration of all clients of the CaloDetDescrManager
.
Also dropped several classes, which apparently have no clients in the master branch:
CaloDmCell
CaloDmEnergy
CaloDmNeighbours
Merge request reports
Activity
This merge request affects 1 package:
- Calorimeter/CaloCalibHitRec
This merge request affects 12 files:
- Calorimeter/CaloCalibHitRec/CaloCalibHitRec/CalibHitToCaloCell.h
- Calorimeter/CaloCalibHitRec/CaloCalibHitRec/CalibHitToCaloCellTool.h
- Calorimeter/CaloCalibHitRec/CaloCalibHitRec/CaloCalibClusterMomentsMaker.h
- Calorimeter/CaloCalibHitRec/CaloCalibHitRec/CaloCalibClusterMomentsMaker2.h
- Calorimeter/CaloCalibHitRec/CaloCalibHitRec/CaloCalibClusterTruthAttributerTool.h
- Calorimeter/CaloCalibHitRec/CaloCalibHitRec/CaloDmEnergy.h
- Calorimeter/CaloCalibHitRec/CaloCalibHitRec/CaloDmNeighbours.h
- Calorimeter/CaloCalibHitRec/CaloCalibHitRec/ICaloCalibClusterTruthAttributerTool.h
- Calorimeter/CaloCalibHitRec/src/CalibHitToCaloCell.cxx
- Calorimeter/CaloCalibHitRec/src/CalibHitToCaloCellTool.cxx
- Calorimeter/CaloCalibHitRec/src/CaloDmEnergy.cxx
- Calorimeter/CaloCalibHitRec/src/CaloDmNeighbours.cxx
Adding @pavol as watcher
added Calorimeter JetEtmiss master review-pending-level-1 labels
removed review-pending-level-1 label
added review-pending-expert label
- Resolved by Sven Menke
Hi @pavol ,
Could you please confirm that you are OK with these changes? In particular with the removal of the classes I mentioned in the description of this MR. I could not find any use of these classes in the master.
Since we are on it, I think the
CaloCalibHitRec
can use some reorganization. It can be turned into a component-only package. For this we need to find some other packages forICaloCalibClusterTruthAttributerTool.h
and forCaloCalibDefineTypes.h
, and naturally move all remaining.h
files tosrc
. This reorganization can be done later in a separate MR.Thanks!
CI Result SUCCESS (hash d5fb5db6)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39576]Hi @tsulaia,
fine with me as well, this should go ahead, pushing to standard review process.
Thanks, Pavol
added review-pending-level-1 label and removed review-pending-expert label
added review-approved label and removed review-pending-level-1 label
mentioned in commit 44f1d3c0
added sweep:ignore label