Skip to content
Snippets Groups Projects

TriggerMenuMT: remove usage of TriggerFlags for menu generation

Merged Frank Winklmeier requested to merge fwinkl/athena:tmmt_signatures into master

Remove the usage of TriggerFlags.XYZSlice.signatures in the menu generation. The only hook to modify the list of signatures externally is the setChainFilter method. So there is no need to even expose the list of signatures outside the TriggerMenuMT package via flags:

  • Introduce ChainStore class/dict that holds the list of chains per signature. Also takes care of only allowing a fixed set of signature names.
  • setupMenu() return a ChainStore that is used in GenerateMenuMT.
  • Adapt runHLT_standalone.py to the chain filter changes.

Closes ATR-24201.

Edited by Frank Winklmeier

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniele Zanzi
  • :negative_squared_cross_mark: CI Result FAILURE (hash a41f2a93)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39591]

  • Frank Winklmeier resolved all threads

    resolved all threads

  • Frank Winklmeier changed the description

    changed the description

  • Frank Winklmeier added 57 commits

    added 57 commits

    • a41f2a93...598aebb9 - 56 commits from branch atlas:master
    • 404fc64a - TriggerMenuMT: remove usage of TriggerFlags for signature generation

    Compare with previous version

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 148K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/LS2_v1.py

  • This merge request affects 2 packages:

    • Trigger/TriggerCommon/TriggerJobOpts
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@ademaria ,@iriu ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

  • :white_check_mark: CI Result SUCCESS (hash 404fc64a)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39655]

  • Frank Winklmeier added 24 commits

    added 24 commits

    • 404fc64a...a8fa2f71 - 23 commits from branch atlas:master
    • cb3f8f01 - TriggerMenuMT: remove usage of TriggerFlags for signature generation

    Compare with previous version

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 148K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/LS2_v1.py

  • :pencil: :pushpin: build area is cleaned as the previous build was for the MR labeled as full-build

  • This merge request affects 2 packages:

    • Trigger/TriggerCommon/TriggerJobOpts
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@ademaria ,@iriu ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading