Formatted strings in histogram aliases
This extends the existing functionality of the GenericMonitoringArray class to allow for string.format within histogram aliases. Tests have been updated accordingly.
Resolves ATLASDQ-885.
Merge request reports
Activity
This merge request affects 2 packages:
- Control/AthenaMonitoring
- Control/AthenaMonitoringKernel
Affected files list will not be printed in this case
Adding @ssnyder as watcher
added Core DQ master review-pending-level-1 labels
I should add, this could technically fail if a user did something incredibly pathological like
array = helper.addArray([['{0}', '{1}']], ...) array.defineHistogram('var;alias_{0}_formatted', ...)
In that event, GenericMonitoringArray.defineHistogram would produce:
alias_{0}_formatted_{0}
alias_{1}_formatted
(I would argue that we can ignore this edge case.)
CI Result FAILURE (hash 6d089d15)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39693]added review-user-action-required label and removed review-pending-level-1 label
added 46 commits
-
6d089d15...1098192a - 44 commits from branch
atlas:master
- f66fcd4b - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into master-FormatStringTitles
- a7562f2a - undo change to formatted path example histogram; update unit tests
-
6d089d15...1098192a - 44 commits from branch
This merge request affects 2 packages:
- Control/AthenaMonitoring
- Control/AthenaMonitoringKernel
Affected files list will not be printed in this case
Adding @ssnyder as watcher
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash a7562f2a)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39723]added review-approved label and removed review-pending-level-1 label
mentioned in commit df05eb81
added sweep:ignore label