Skip to content
Snippets Groups Projects

Sort HLT and L1 histogram x-axes alphabetically

All threads resolved!

This addresses issues discussed in [ATR-21172] and [ATR-19976] by alphabetically sorting the x-axes of the histograms monitoring L1 items and HLT chains.
Currently, the histograms monitoring L1 items and HLT chains which are fired in the run, are filled in the order the events happen to be processed. This means that the shape of the histograms can differ quite dramatically for reasons purely to do with process ordering, which is clearly not the desired behaviour.

After the change, we will have these improvements:

  • Reprocessing the same run without changing the menu will result in an identical histogram.
  • If the menu is changed (by removing or adding a few chains) the x-axis will shift a little bit in a way which is clearly recognisable.
  • All histograms from a particular signature will end up together. (With the exception of multi-ele/jet/muon/etc where HLT_2jX_blabla will be closer to HLT_2eX_blabla than to HLT_jX_blabla )

Example of desired behaviour (Run 2 code): https://atlas.web.cern.ch/Atlas/project/trigger/trigcaf/www/ATR-24194-legacy/ResultMon/L1Events.html
What is currently looks like in Run 3 code: https://atlas.web.cern.ch/Atlas/project/trigger/trigcaf/www/ATR-24194-run3/ResultMon/L1Events.html (data and reference disagree artificially even though there was no change).

CC: @astruebi , @palacino

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :negative_squared_cross_mark: CI Result FAILURE (hash 923e27a9)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39793]

  • added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/TrigMonitoring/TrigHLTMonitoring

    This merge request affects 2 files:

    • Trigger/TrigMonitoring/TrigHLTMonitoring/python/TrigGeneralMonitorAlgorithm.py
    • Trigger/TrigMonitoring/TrigHLTMonitoring/src/TrigHLTMonitorAlgorithm.cxx

    Adding @ebergeas as watcher

  • :white_check_mark: CI Result SUCCESS (hash 8f649208)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39803]

  • Volker Andreas Austrup resolved all threads

    resolved all threads

  • Hi,

    changes look good from L1 side, CI is all green now. Approving.

    Cheers, Volker (L1)

  • mentioned in commit 9ff8baf5

  • Please register or sign in to reply
    Loading