Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 152
    • Merge requests 152
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !46931

Dropped GeoLArHit

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Vakhtang Tsulaia requested to merge tsulaia/athena:master-geolarhit into master Oct 05, 2021
  • Overview 12
  • Commits 5
  • Pipelines 1
  • Changes 18

The benefits coming from the usage of this class are rather questionable. On the other hand, it uses AthenaMT-unfriendly way of retrieving a pointer to the CaloDetDescrManager and caching it.

The clients of GeoLArHit had been switched to the direct usage of LArHit and CaloDetDescrManager interfaces, and subsequently, the GeoLArHit class was dropped.

The migration of individual client classes were implemented in separate commits in order to facilitate the code review.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-geolarhit