Change the return type of sTgcDigitMaker helper functions to StatusCode
Helper functions that read parameters from txt files print out fatal messages upon failure. It was suggested in MR !46903 (merged) to edit these functions to return StatusCode. Additional changes are: deletion of an unused function efficiencyCheck(const int) and suppression of some messages. This function efficiencyCheck, in addition to be unused, has a bug that can potentially cause confusion.
Merge request reports
Activity
mentioned in merge request !46903 (merged)
This merge request affects 1 package:
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
This merge request affects 3 files:
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/sTGC_Digitization/sTgcDigitMaker.h
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/src/sTgcDigitMaker.cxx
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/src/sTgcDigitizationTool.cxx
Adding @jchapman ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
added Digitization MuonSpectrometer master labels
CI Result FAILURE (hash b7dda557)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39855]This merge request affects 1 package:
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
This merge request affects 3 files:
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/sTGC_Digitization/sTgcDigitMaker.h
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/src/sTgcDigitMaker.cxx
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/src/sTgcDigitizationTool.cxx
Adding @jchapman ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
CI Result SUCCESS (hash b7dda557)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39883]added 76 commits
-
b7dda557...f87dc9a7 - 73 commits from branch
atlas:master
- d9be69d4 - Change the helper functions to return StatusCode
- 3690df1a - Suppress some messages from INFO to VERBOSE
- 5dae44c2 - Delete unused efficiencyCheck(int), clean comments
Toggle commit list-
b7dda557...f87dc9a7 - 73 commits from branch
added 1 commit
- 5cdbceda - Edit one more helper function to return StatusCode
This merge request affects 1 package:
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
This merge request affects 3 files:
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/sTGC_Digitization/sTgcDigitMaker.h
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/src/sTgcDigitMaker.cxx
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/src/sTgcDigitizationTool.cxx
Adding @jchapman ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
added review-pending-level-1 label
CI Result SUCCESS (hash 5cdbceda)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39963]added review-approved label and removed review-pending-level-1 label
mentioned in commit 06d46c83