Skip to content
Snippets Groups Projects

A few methods implemented in version 2 of Run2ToRun3 code

Merged Witold Wojciech Przygoda requested to merge wprzygod/athena:exploreRelease into master

New (version 2): associateChainsToProxies and extractTECtoChainMapping implemented Old version: optional code selector for various approach.
Test unit: temporarliy disabled (commented out).

Edited by Witold Wojciech Przygoda

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested review from @tbold

  • This merge request affects 1 package:

    • Trigger/TrigEvent/TrigNavTools

    This merge request affects 7 files:

    • Trigger/TrigEvent/TrigNavTools/CMakeLists.txt
    • Trigger/TrigEvent/TrigNavTools/share/NavConverter_muon_multichains_test.ref
    • Trigger/TrigEvent/TrigNavTools/share/testTrigR2ToR3NavGraphConversion.py
    • Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverter.cxx
    • Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverter.h
    • Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverterV2.cxx
    • Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverterV2.h
    • Resolved by Tomasz Bold

      :negative_squared_cross_mark: CI Result FAILURE (hash 5dd96a4f)

      Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
      externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

      Full details available on this CI monitor view
      :white_check_mark: Athena: number of compilation errors 0, warnings 0
      :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
      :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
      :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
      :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
      :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39895]

  • added 1 commit

    • 74ff5621 - test unit temporarily disabled

    Compare with previous version

  • Witold Wojciech Przygoda changed the description

    changed the description

  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates. However the GitLab pipelines status may be shown incorrectly.

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • Trigger/TrigEvent/TrigNavTools

    This merge request affects 9 files:

    • Trigger/TrigEvent/TrigNavTools/CMakeLists.txt
    • Trigger/TrigEvent/TrigNavTools/share/NavConverter_electron_multichains_test.ref
    • Trigger/TrigEvent/TrigNavTools/share/NavConverter_muon_chains_test.ref
    • Trigger/TrigEvent/TrigNavTools/share/NavConverter_muon_multichains_test.ref
    • Trigger/TrigEvent/TrigNavTools/share/testTrigR2ToR3NavGraphConversion.py
    • Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverter.cxx
    • Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverter.h
    • Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverterV2.cxx
    • Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverterV2.h
  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates. However the GitLab pipelines status may be shown incorrectly.

  • Tomasz Bold
  • Tomasz Bold
  • Tomasz Bold
  • Tomasz Bold
  • Suggested few improvements (rather minor). Since we are a bit in a rush with this development I suggest closing those and addressing them in the next MR. Unless there will be a need for another CI cycle. They would then be worth addressing.

    Side observation. This MR has 106 commits that span several months. Most are irrelevant by now. They will be all squashed when joining with the master but I really suggest following ATLAS guide and make a separate branch for each MR.

  • :white_check_mark: CI Result SUCCESS (hash 74ff5621)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39908]

  • ok, CI looks ok. I'll resolve comments so this MR can move ahead with the understanding of the fixes to be done in the next MR.

  • Tomasz Bold resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading