A few methods implemented in version 2 of Run2ToRun3 code
New (version 2): associateChainsToProxies and extractTECtoChainMapping implemented
Old version: optional code selector for various approach.
Test unit: temporarliy disabled (commented out).
Merge request reports
Activity
requested review from @tbold
This merge request affects 1 package:
- Trigger/TrigEvent/TrigNavTools
This merge request affects 7 files:
- Trigger/TrigEvent/TrigNavTools/CMakeLists.txt
- Trigger/TrigEvent/TrigNavTools/share/NavConverter_muon_multichains_test.ref
- Trigger/TrigEvent/TrigNavTools/share/testTrigR2ToR3NavGraphConversion.py
- Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverter.cxx
- Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverter.h
- Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverterV2.cxx
- Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverterV2.h
added Trigger master review-pending-level-1 labels
- Resolved by Tomasz Bold
CI Result FAILURE (hash 5dd96a4f)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39895]
This merge request affects 1 package:
- Trigger/TrigEvent/TrigNavTools
This merge request affects 9 files:
- Trigger/TrigEvent/TrigNavTools/CMakeLists.txt
- Trigger/TrigEvent/TrigNavTools/share/NavConverter_electron_multichains_test.ref
- Trigger/TrigEvent/TrigNavTools/share/NavConverter_muon_chains_test.ref
- Trigger/TrigEvent/TrigNavTools/share/NavConverter_muon_multichains_test.ref
- Trigger/TrigEvent/TrigNavTools/share/testTrigR2ToR3NavGraphConversion.py
- Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverter.cxx
- Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverter.h
- Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverterV2.cxx
- Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverterV2.h
- Resolved by Tomasz Bold
- Resolved by Tomasz Bold
- Resolved by Witold Wojciech Przygoda
- Resolved by Tomasz Bold
- Resolved by Tomasz Bold
Suggested few improvements (rather minor). Since we are a bit in a rush with this development I suggest closing those and addressing them in the next MR. Unless there will be a need for another CI cycle. They would then be worth addressing.
Side observation. This MR has 106 commits that span several months. Most are irrelevant by now. They will be all squashed when joining with the master but I really suggest following ATLAS guide and make a separate branch for each MR.
CI Result SUCCESS (hash 74ff5621)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39908]