MagFieldElements+MagFieldServices: Fix cppcheck warnings.

Merged Scott Snyder requested to merge ssnyder/athena:cppcheck.MagFieldElements-20211005 into master

Prefer to initialize members in an initializer list rather than in a ctor body.

Remove unneeded c_str() calls.

Protect against potential null pointer dereference.

Merge request reports