Adding relbcid to MM RDO
This merge request adds the relBCID to the RDO of the Micromegas. This is needed to be able to process real data. For now, the digitization does not decompose the time measurement into the relBCID at TDO but maybe should do so at some point in the future. This MR breaks the readability of old RDO files.
Merge request reports
Activity
This merge request affects 5 packages:
- MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
- MuonSpectrometer/MuonCnv/MuonEventTPCnv
- MuonSpectrometer/MuonCnv/MuonMM_CnvTools
- MuonSpectrometer/MuonRDO
- MuonSpectrometer/MuonValidation/MuonPRDTest
Affected files list will not be printed in this case
Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
added MuonSpectrometer master review-pending-level-1 labels
CI Result SUCCESS (hash 1ca7a417)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39973]added review-approved label and removed review-pending-level-1 label
mentioned in commit 91b5396b
added sweep:ignore label
- Resolved by Patrick Scholer
Didn't we conclude that 21.3 is depreciated? If there's a development which can only be performed in 21.3 or 21.9 feel free to sweep it. Otherwise we just consider this as one of the unique improvements when working with master
Edited by Johannes Junggeburth
Hi @tadej, this MR broke the ability to read old RDO files containing the NSW, since I had to add a variable the MM RDO. Now my question is if I should sweep this to 21.9. I assume that you cannot read RDOs produced in 21.9 with master at the moment (not sure if this is relevant), but sweeping might break reading any old RDO file in 21.9 as well. Cheers, Patrick
Hi @pscholer, @jojungge, @rosati, Err - why did we update the
MM_RawData_p1
persistent class? When a change of this type is made we should make a new persistent version... Unfortunately this one did not get the Digitization label otherwise I would have mentioned this earlier.Cheers,
John
Hi @jchapman, when adding things in the 21.3 EDM in the past I did not break the readability so I expected that this one also does not break things... Otherwise I would have done it with the new version. Sorry. If this is critical, can we undo the changes to the p1 and introduce a p2? This would then invalidate RDOs produced in the last week, but probably allow to read older RDOs again. Cheers, Patrick
Edited by Patrick ScholerIt's just that we are very close to starting to run production of Run3 samples now, so when validating sometimes we want to be able to read files from older releases with newer releases. If you could introduce a p2 class + TP converter and update the old p1 TP converter to fill the relBCID variable with zero, that would be great. @jojungge and @rosati do you agree?
Cheers,
John
Hi @jchapman , yes, it's better if we keep the ability of reading old releases files. thanks, cheers, Stefano
Edited by Stefano Rosatimentioned in merge request !47492 (merged)