Initialize sTgcDigitMaker once per sTgcDigitizationTool class declaration
Moving the sTgcDigitMaker initialization to right after the class declaration in the sTgcDigitizationTool::initialize method, so that sTgcDigitMaker is initialized only once. Since the parameters read from files during sTgcDigitMaker initialization are the same, there is no reason to re-read the files at each event. Also, a random engine is not required by the sTgcDigitMaker::initialize method. So the member object HepRandomEngine is deleted and, instead, a pointer to an element of IAthRNGSvc is used when shooting random numbers. This modification was suggested, see comments at MR !46472 (merged).
Merge request reports
Activity
This merge request affects 1 package:
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
This merge request affects 3 files:
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/sTGC_Digitization/sTgcDigitMaker.h
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/src/sTgcDigitMaker.cxx
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/src/sTgcDigitizationTool.cxx
Adding @jchapman ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
added Digitization MuonSpectrometer master review-pending-level-1 labels
CI Result SUCCESS (hash e9f2e079)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40044]added review-approved label and removed review-pending-level-1 label
mentioned in commit cdaacd0e
added sweep:ignore label