Fix threading issues in HLT prescale loading but for real
This MR is doing what !44936 (merged) claimed to do but missed the change in the most important two lines.
[L1|HLT]PrescaleCondAlg
: Use thread-safeinsert
to add elements totbb::concurrent_unordered_map
instead ofoperator[]
+ assignment which is unsafe.
!44936 (merged) did this only in two calls in initialize()
of each algorithm, but missed the one that was actually causing crashes/errors which was in execute()
.
Fixes ATR-23670 though it's unfortunately impossible to test this due to how rare this race condition is. We'll deploy this at P1 ASAP and hope we don't see the errors ever again.
Merge request reports
Activity
This merge request affects 1 package:
- Trigger/TrigConfiguration/TrigConfigSvc
This merge request affects 2 files:
- Trigger/TrigConfiguration/TrigConfigSvc/src/HLTPrescaleCondAlg.cxx
- Trigger/TrigConfiguration/TrigConfigSvc/src/L1PrescaleCondAlg.cxx
Adding @orlando ,@cmorenom ,@mark ,@paulama ,@asonay as watchers
added Trigger master review-pending-level-1 labels
CI Result SUCCESS (hash e929c68d)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40095]added review-approved label and removed review-pending-level-1 label
mentioned in commit 1af73b1d
added sweep:ignore label