remove AsgTools::setName()

We discussed that a long time ago and I thought I had already done it, but apparently not: Essentially we do not advertise any workflows in which the name of components can/ought to be changed after the fact, and it is liable to cause issues unless strict precautions are taken. So the solution was/is to just remove AsgTools::setName().

I tested that package compiles by itself, but I'll rely on the CI to see if it throws up problems in other packages.

This merge request affects 1 package:

• Control/AthToolSupport/AsgTools

This merge request affects 5 files:

• Control/AthToolSupport/AsgTools/AsgTools/AsgTool.h
• Control/AthToolSupport/AsgTools/AsgTools/IAsgTool.h
• Control/AthToolSupport/AsgTools/AsgTools/ToolStore.h
• Control/AthToolSupport/AsgTools/Root/AsgTool.cxx
• Control/AthToolSupport/AsgTools/Root/ToolStore.cxx

Adding @krumnack ,@ssnyder as watchers

added Core analysis-review-required master review-pending-level-1 labels

CI Result FAILURE (hash 2d245c22)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40173]

I think the errors CI are not related to this MR. Approved

Sergei L1

added review-approved label and removed review-pending-level-1 label

added analysis-review-approved label and removed analysis-review-required label

Jenkins please retry a build

This merge request affects 1 package:

• Control/AthToolSupport/AsgTools

This merge request affects 5 files:

• Control/AthToolSupport/AsgTools/AsgTools/AsgTool.h
• Control/AthToolSupport/AsgTools/AsgTools/IAsgTool.h
• Control/AthToolSupport/AsgTools/AsgTools/ToolStore.h
• Control/AthToolSupport/AsgTools/Root/AsgTool.cxx
• Control/AthToolSupport/AsgTools/Root/ToolStore.cxx

Adding @krumnack ,@ssnyder as watchers

added analysis-review-required review-pending-level-1 labels and removed review-approved label

CI Result FAILURE (hash 2d245c22)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40323]

Hi, @wlampl. The build error has been repeated. Do you think it's related?

Sergei L1

There are errors like

ESDtoAOD 21:21:44 m_LHTool2015                                          INFO initialize : WP 0 95
ESDtoAOD 21:21:44 Package.AsgTools.AnaToolHandle                       ERROR /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgTools/Root/ToolStore.cxx:48 (static StatusCode asg::ToolStore::put(asg::IAsgTool*)): asg::ToolStore::put: Tool with name "m_LHTool2015" already registered

in the log. That might be related - or this change exposed another bug.

In any case, the author of this MR (@krumnack) is among the most qualified persons to debug this kind of problems.

• Walter

added review-user-action-required label

removed review-pending-level-1 label

added 280 commits

• 2d245c22...096e3578 - 279 commits from branch atlas:master
• 724dc7cf - remove AsgTools::setName()

Compare with previous version

This merge request affects 1 package:

• Control/AthToolSupport/AsgTools

This merge request affects 7 files:

• Control/AthToolSupport/AsgTools/AsgTools/AsgTool.h
• Control/AthToolSupport/AsgTools/AsgTools/IAsgTool.h
• Control/AthToolSupport/AsgTools/AsgTools/MessageCheckAsgTools.h
• Control/AthToolSupport/AsgTools/AsgTools/ToolStore.h
• Control/AthToolSupport/AsgTools/Root/AsgTool.cxx
• Control/AthToolSupport/AsgTools/Root/MessageCheckAsgTools.cxx
• Control/AthToolSupport/AsgTools/Root/ToolStore.cxx

Adding @krumnack ,@ssnyder as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 724dc7cf)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40390]

resolved all threads

removed review-pending-level-1 label