Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 159
    • Merge requests 159
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !47346

The get/pop CA method cause exception if looked for component is missing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tomasz Bold requested to merge tbold/athena:make-get-mehhods-fail-when-missing into master Oct 18, 2021
  • Overview 30
  • Commits 2
  • Pipelines 6
  • Changes 4

Functionality added by this MR is related to new/CA JO. The CAs can be queried for components (i.e. public tools). Typically when no object is found this means a mistake (typo in the name for instance). With this change, such a mistake would result in an exception being raised. This is the default behaviour. In cases when it is actually possible that the component is missing additional option can be provided: acceptAbsent. Then client code can check if the returned value is None and act accordingly.

Tagging @wlampl @mhodgkin @emoyse @goetz @fwinkl @rbielski PS> Launching all unit tests to catch possible mistakes in all areas.

Edited Oct 23, 2021 by Tomasz Bold
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: make-get-mehhods-fail-when-missing