Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !47382

RpcDigitizationTool -- Introduce checks on identifier validity

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Johannes Junggeburth requested to merge jojungge/athena:rpc_digi_phase_II into master Oct 19, 2021
  • Overview 20
  • Commits 4
  • Pipelines 0
  • Changes 8

Hi,

this MR comprises: *** Clang-format of the RPC_Digitization package *** Declaring class-methods of RPC_DigitizationTool as const where data is obviously just read *** Check that simulation identifiers point to barrel elements and that no BIS8 identifier is actually used. Prompt WARNINGS in the catcher cases *** Update of the test_digi_phase2 script in MuonRecRTT

This MR should essentially remove the crashes in the phase II geometry observed when running over a large number of events. It does not remove the actual cause of the crashes which are wrong identifiers saved in the HITS files.

Tagging: @tadej, @npetters

Closes ATLASSIM-5320, ATLASRECTS-6345

Edited Oct 20, 2021 by Johannes Junggeburth
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rpc_digi_phase_II