Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 131
    • Merge requests 131
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !47456

LArRegionSelector+RegionSelector: Cleaning up use of LArCablingLegacyService.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Scott Snyder requested to merge ssnyder/athena:legacy2.LArRegionSelector-20211021 into master Oct 21, 2021
  • Overview 3
  • Commits 2
  • Pipelines 1
  • Changes 4

Cleaning up use of LArCablingLegacyService, so that it can be deleted.

Change from using the LArRoI_Map tool to the LArRoIMap conditions object. Can then remove dummy dependency on LArOnOffIdMapping.

Don't write anything at INFO level from a component constructor --- otherwise we get ugly output during genconf.

Add dependencies to the configuration to configure the LArRoIMap conditions algorithm.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: legacy2.LArRegionSelector-20211021