Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 150
    • Merge requests 150
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !47499

ILayerBuilderCond does not need to return the new Layers it creates as const

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:ILayerBuilderCond_factory_non_const_return into master Oct 21, 2021
  • Overview 6
  • Commits 1
  • Pipelines 1
  • Changes 16

ILayerBuilderCond creates new Layers which then pass on,acts as a "factory". These new Layers do not need to be const. Being const unneedlessy leads down the chain to uneeded const_cast (Explicit or implicit) and other syntactic or actual issues.

ping @rlangenb as we discussed this , note that I do this only for the "cond" tools , I assume the older legacy non condition tools used by the svc will be eventually removed.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ILayerBuilderCond_factory_non_const_return