Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 147
    • Merge requests 147
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !47672

Remove variables availability check in MuonSelectorToolsTester

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Magnar Kopangen Bugge requested to merge mkbugge/athena:21.2-MSTTremoveVariablesChecks into 21.2 Oct 27, 2021
  • Overview 10
  • Commits 1
  • Pipelines 1
  • Changes 1

This MR removes some lines from MuonSelectorToolsTester. These lines check the availability of certain variables used in the muon selection, and prints a message if they are missing. They can cause a crash in rare circumstances, if the primary track pointer of the muon is a null pointer. Rather than implementing a null pointer test, I prefer to remove the lines because the list of variables checked is not exhaustive of all variables used in the muon selection. There is no point in fixing this and spending effort on keeping this part up to date, because the MuonSelectionTool itself prints a warning for any missing variables, which will show up in any case when running the tester.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 21.2-MSTTremoveVariablesChecks