Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 169
    • Merge requests 169
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !47748

Tracking: Customisation of hitLocalToLocal for polar co-ordinates

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged James Smith requested to merge jlsmith/athena:dev/21.9/polarHits into 21.9 Oct 28, 2021
  • Overview 33
  • Commits 7
  • Pipelines 4
  • Changes 9

In the course of debugging the polar co-ordinate implementation integrated in !44381 (merged), it was found that in the digitisation co-ordinates are read from the HITS file and passed to the polar design class as cartesian.

This MR creates a specialisation of the hitLocalToLocal method to detect if a polar endcap is being used, and then applies a conversion to polar co-orinates.

The polar endcap is detected by defining a new detector shape enum, which is only returned when the design has been created with polar endcaps, which is ultimately controlled by an additional flag in the geometry file. This ensures that other workflows are unaffected.

The conversion to polar co-ordinates uses standard library functions to minimise the additional CPU cost. It is hoped that performing the transformation here will be quicker than repeatedly performing it in the digitisation and reconstruction.

This is in support of ATLITKSW-42.

Tags: @nstyles @hhayward @pagessin

Edited Oct 29, 2021 by James Smith
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dev/21.9/polarHits