Skip to content

More thorough type-checking of lists in ChainProp construction

Teng Jian Khoo requested to merge khoo/athena:master-TMMT-ThoroughChainPropTypeCheck into master

The type-checking in ChainProp only checked the type of the first element in a list. This meant that a ChainProp definition with nested group lists like

ChainProp(name='HLT_mb_sptrk_L1MBTS_1', l1SeedThresholds=['FSNOSEED'], stream=[PhysicsStream], groups=['PS:Online',MinBiasGroup]+LowMuGroup)

passed the test, and failed only downstream.

Checking every element instead with such a ChainProp in the menu crashes as intended:

TypeError: Expected type of 'groups' to be typing.List[str], got ['PS:Online', ['RATE:MinBias', 'BW:MinBias'], 'Primary:LowMu']

Merge request reports