Configure trigger data conversion in new JO

Addresses: ATR-24520 to be expanded to cover Run3 (not sure how to test) and Run1.

Tagging @fwinkl @tamartin @rbielski A suggestion of which tests to run would be useful

Nice! MRs that have a negative overall line count always get a

I think any RAWtoALL (q431) should test this sufficiently.

Also to try and head off a conflict, note I made some additional simplifications to Trigger/TriggerCommon/TriggerJobOpts/python/TriggerConfigGetter.py on !48007 (closed)

added 1 commit

• 604f9482 - Debugged BS extraction

Compare with previous version

marked this merge request as ready

This merge request affects 2 packages:

• Reconstruction/RecJobTransforms
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @goetz as watcher

added Reconstruction Trigger master review-pending-level-1 labels

CI Result FAILURE (hash 604f9482)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 42122]

Interesting, we get a merge error for the (Dlls) property of HLT::Navigation/ToolSvc.Navigation

Can we unify this with (what I think) is the more common which is = [e for e in EDMLibraries if 'TPCnv' not in e]

Setting review-user-action-required for now as there are still unresolved threads and trouble with the CI.

Cheers, Martin (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 182 commits

• 604f9482...9baed681 - 179 commits from branch atlas:master
• e18def60 - Restore HLTTriggerResultGetter
• 8a01d765 - Merge remote-tracking branch 'upstream/master' into trigger-data-decoding
• e4e4f0c6 - Went back to old code for decision conversion

Compare with previous version

This merge request affects 2 packages:

• Reconstruction/RecJobTransforms
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @goetz as watcher

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash e4e4f0c6)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 42259]

Warnings related and resolve open thread

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerJobOpts/python/TriggerRecoConfig.py:158:16: warning: ATL900: Do not assign an explicit OutputLevel
    decMaker = CompFactory.TrigDec.TrigDecisionMaker( "TrigDecMaker", 
               ^
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerJobOpts/python/TriggerRecoConfig.py:186:23: warning: ATL900: Do not assign an explicit OutputLevel
    acc.addEventAlgo( CompFactory.xAODMaker.TrigNavigationCnvAlg('TrigNavigationCnvAlg', 

Sergei L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 1f701eb8 - Fixed comp. warnings

Compare with previous version

This merge request affects 2 packages:

• Reconstruction/RecJobTransforms
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @goetz as watcher

added review-pending-level-1 label and removed review-user-action-required label