Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 153
    • Merge requests 153
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !48207

Common DetectorTool for all GeoModelXml-based geometries

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nicholas Styles requested to merge nstyles/athena:master-DetFactoryCleanup_part2 into master Nov 12, 2021
  • Overview 81
  • Commits 16
  • Pipelines 10
  • Changes 8

...as above. Try to make a generic base class to avoid duplication of code across different systems, plus some clean-up, and new functionality.

Implementing use of this first for StripDetectorTool as an example, to get feedback before using it also for Pixel/HGTD/PLR, etc...

The DetectorTool now does the job of the DetectorFactory too, to avoid awkward passing on of Athena services and properties that was previously necessary. Dependence on AthenaBaseComps is removed, as are StripOptions.

Moving ITkStrip first, all other GeoModeXml-based geometries should then follow this pattern too, to be able to make use of the common base class.

FYI @dshope @dfellers @sridouan @tsulaia @boudreau @dellacqu

Edited Dec 10, 2021 by Nicholas Styles
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-DetFactoryCleanup_part2