Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 142
    • Merge requests 142
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !48267

Merged
Created Nov 16, 2021 by Tomas Dado@tdadoDeveloper

AnalysisTop: Do not setup the ChargeMisID tool when unsupported WPs are requested

  • Overview 18
  • Commits 2
  • Pipelines 4
  • Changes 2

Don't setup the tool if the WP is not supported. This makes the other parts of the code simply return SF = 1.

Previously we setup the tool with some dummy values, which then resulted in dummy SFs that were then ignored later down the code. However, if someone was using the intermediate functions the returned values were wrong. This change makes things more transparent.

cc @fcardill @maniemey

Edited Nov 16, 2021 by Tomas Dado
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 21.2-AnalysisTop-ElectronChargeMisIDSF