Prevent CP algorithms from copying the EventInfo collection

This is a cherry-pick of a24324e3 from 21.2.

I had to comment out some config files that don't seem to work in R22, that should be fixed separately. For now I'd rather have consistent code between 21.2 and master. From what I can tell this doesn't actually break anything, but the tests that are failing are essentially new.

I also added a second commit that allows to call configure on the pileup sequence (again) like for any other CP algorithm sequence. It is a no-op right now, but since it does more than just manage the temporary copies, I figured it is better to keep it around. This will have to be (manually) swept back into 21.2 once this is merged.

cc @jburr

This merge request affects 6 packages:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/EgammaAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/MuonAnalysisAlgorithms
• PhysicsAnalysis/AnalysisCommon/PileupReweighting
• PhysicsAnalysis/Interfaces/AsgAnalysisInterfaces

Affected files list will not be printed in this case

Adding @zmarshal ,@akraszna ,@krumnack ,@tadej ,@pagessin as watchers

added Analysis Egamma JetEtmiss analysis-review-required master review-pending-level-1 labels

CI Result FAILURE (hash 4626a71b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 42315]

Hi @krumnack I see several unit tests failing with Unrecognised periodNumber or no data loaded errors. As well as

AODtoDAOD 00:18:45 Shortened traceback (most recent user call last):
AODtoDAOD 00:18:45   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/jobOptions/PATJobTransforms/skeleton.AODtoDAOD_tf.py", line 112, in <module>
AODtoDAOD 00:18:45     else: include( "RecExCommon/RecExCommon_topOptions.py" )
AODtoDAOD 00:18:45   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/jobOptions/RecExCommon/RecExCommon_topOptions.py", line 1031, in <module>
AODtoDAOD 00:18:45     include(DPDMaker)
AODtoDAOD 00:18:45   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/jobOptions/DerivationFrameworkPhys/PHYSLITE.py", line 189, in <module>
AODtoDAOD 00:18:45     pileupSequence.configure( inputName = 'EventInfo', outputName = 'EventInfo_%SYS%' )
AODtoDAOD 00:18:45   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AnaAlgorithm/AnaAlgSequence.py", line 176, in configure
AODtoDAOD 00:18:45     for inputLabel, inputKey in meta.inputPropName.items():
AODtoDAOD 00:18:45 
AODtoDAOD 00:18:45 AttributeError: 'NoneType' object has no attribute 'items'

-- L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• ef81230f - Prevent CP algorithms from copying the EventInfo collection

Compare with previous version

This merge request affects 6 packages:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/EgammaAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/MuonAnalysisAlgorithms
• PhysicsAnalysis/AnalysisCommon/PileupReweighting
• PhysicsAnalysis/Interfaces/AsgAnalysisInterfaces

Affected files list will not be printed in this case

Adding @zmarshal ,@akraszna ,@krumnack ,@tadej ,@pagessin as watchers

added review-pending-level-1 label and removed review-user-action-required label

changed the description

added 1 commit

• d4d4807e - Prevent CP algorithms from copying the EventInfo collection

Compare with previous version

This merge request affects 6 packages:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/EgammaAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/MuonAnalysisAlgorithms
• PhysicsAnalysis/AnalysisCommon/PileupReweighting
• PhysicsAnalysis/Interfaces/AsgAnalysisInterfaces

Affected files list will not be printed in this case

Adding @zmarshal ,@akraszna ,@krumnack ,@tadej ,@pagessin as watchers

changed the description

Thanks for taking care of this! It slipped down my TODO list sadly (I think I must have run into the same problems you had)...

added analysis-review-approved label

CI Result FAILURE (hash ef81230f)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 42363]

CI Result FAILURE (hash d4d4807e)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 42364]

Hi @krumnack,

there is still an error in RecoPHYSLITEFormatTest that looks to be related:

AODtoDAOD 13:02:48 Py:MetaReader        INFO MetaReader is called with the parameter "unique_tag_info_values" set to True. This is a workaround to remove all duplicate values from "/TagInfo" key
AODtoDAOD 13:02:48 Shortened traceback (most recent user call last):
AODtoDAOD 13:02:48   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/jobOptions/PATJobTransforms/skeleton.AODtoDAOD_tf.py", line 112, in <module>
AODtoDAOD 13:02:48     else: include( "RecExCommon/RecExCommon_topOptions.py" )
AODtoDAOD 13:02:48   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/jobOptions/RecExCommon/RecExCommon_topOptions.py", line 1031, in <module>
AODtoDAOD 13:02:48     include(DPDMaker)
AODtoDAOD 13:02:48   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/jobOptions/DerivationFrameworkPhys/PHYSLITE.py", line 189, in <module>
AODtoDAOD 13:02:48     pileupSequence.configure( inputName = 'EventInfo', outputName = 'EventInfo_%SYS%' )
AODtoDAOD 13:02:48   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AnaAlgorithm/AnaAlgSequence.py", line 176, in configure
AODtoDAOD 13:02:48     for inputLabel, inputKey in meta.inputPropName.items():
AODtoDAOD 13:02:48 
AODtoDAOD 13:02:48 AttributeError: 'NoneType' object has no attribute 'items'

Can you please take a look?

Thanks, Volker (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 80e92bfe - Prevent CP algorithms from copying the EventInfo collection

Compare with previous version

Let's hope that fixes it. Unfortunately my attempts to run the PHYSLITE test locally failed.

This merge request affects 7 packages:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/EgammaAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/MuonAnalysisAlgorithms
• PhysicsAnalysis/AnalysisCommon/PileupReweighting
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys
• PhysicsAnalysis/Interfaces/AsgAnalysisInterfaces

Affected files list will not be printed in this case

Adding @zmarshal ,@akraszna ,@dshope ,@krumnack ,@tadej ,@pagessin as watchers

added Derivation review-pending-level-1 labels and removed review-user-action-required label

added 1 commit

• 4c15db1a - explicitly call configure() for pileup sequence as well

Compare with previous version

This merge request affects 7 packages:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/EgammaAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/MuonAnalysisAlgorithms
• PhysicsAnalysis/AnalysisCommon/PileupReweighting
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys
• PhysicsAnalysis/Interfaces/AsgAnalysisInterfaces

Affected files list will not be printed in this case

Adding @zmarshal ,@akraszna ,@dshope ,@krumnack ,@tadej ,@pagessin as watchers

changed the description

removed analysis-review-required label

CI Result SUCCESS (hash 80e92bfe)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 42458]

CI Result SUCCESS (hash 4c15db1a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 42462]

resolved all threads

Changes look fine. Approving -- L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit c58c9cf9

added sweep:ignore label