Skip to content
Snippets Groups Projects

Adding HGTD config flags

Merged Noemi Calace requested to merge ncalace/athena:master-hgtd-config into master
All threads resolved!

Self-explanatory name, and adapting tracking geometry building to use HGTD_ConfigFlags.

FYI: @tadej @npetters @dshope @aleopold @tstreble @nstyles

Merge request reports

Pipeline #3273587 passed

Pipeline passed for 1023e3f2 on ncalace:master-hgtd-config

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 3 years ago (Nov 23, 2021 12:56pm UTC)

Merge details

  • Changes merged into master with c6e98c9f (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Changes look fine, only minor comments. Could you please have a look if there is any typos, before approving?

  • Noemi Calace added 1 commit

    added 1 commit

    Compare with previous version

  • Noemi Calace resolved all threads

    resolved all threads

  • This merge request affects 3 packages:

    • Control/AthenaConfiguration
    • HighGranularityTimingDetector/HGTD_Config
    • Tracking/TrkConditions/TrackingGeometryCondAlg

    Affected files list will not be printed in this case

    Adding @amorley ,@dshope ,@cohm ,@lshan ,@ssnyder as watchers

  • :white_check_mark: CI Result SUCCESS (hash 1023e3f2)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 42649]

  • Looks good, approving (L2).

  • mentioned in commit c6e98c9f

  • Please register or sign in to reply
    Loading